Fixed a couple of small errors in the code.

CommentFileSizeAuthor
#5 0001-Miscellaneous-fix.patch9 KBpol
#1 0001-Fix-Typo-Boxk-Box.patch6.68 KBpol

Comments

pol’s picture

pol
Location Brussels
commented
Status: Active » Needs review
StatusFileSize
new 0001-Fix-Typo-Boxk-Box.patch6.68 KB
pol’s picture

pol
Location Brussels
commented

I've also noticed that the hook openlayers_init() is in the module openlayers_ui. Why ?

zzolo’s picture

zzolo commented

The hook implementation is pretty well commented. It's doing two things that are both focused on UI messages.

1) Backwards compatibility checks from the move of Presets to Maps. This can be dropped in the 3.x version.
2) OpenLayers library version check. My method of doing this is pretty stupid; it should just be handled by reading and parsing the library in PHP.

http://drupalcode.org/project/openlayers.git/blob/refs/heads/7.x-2.x:/mo...

pol’s picture

pol
Location Brussels
commented

Ok thanks for the explanations.

I will rename the hook in openlayers_ui_init() then.

pol’s picture

pol
Location Brussels
commented
StatusFileSize
new 0001-Miscellaneous-fix.patch9 KB

New patch with some fixes.

pol’s picture

pol
Location Brussels
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.