In function question_settings() (line 193), the question_require_registered variable defaults to FALSE:
'#default_value' => variable_get('question_require_registered', FALSE),
In function theme_question_qform() (line 358), the question_require_registered variable defaults to TRUE:
if (!$user->uid && variable_get('question_require_registered', TRUE)) {
This has the result that before the settings form is submitted for the first time, the 'require registered user' option appears unchecked on the settings page, but is effectively active on the 'ask a question' form.
I propose changing the default in theme_question_qform() to FALSE, so as not to confuse buffoons like myself in future.
(Just FYI: This appears to be the result of a patch back in february, where the codepoet quite sensibly reversed all the logic to change from a || to an &&, but overlooked the fact that it's only the test of the state of the variable_check() that needed to be reversed, and not the default state itself.)
Comments
Comment #1
codepoet commentedDone and done. Thanks. :)
Comment #2
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.