The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.As of 7.x-2.4, localize.drupal.org identifies 3 potential problems with the source code.
My tuppence Initial assessment:
watchdog('@font-your-face',$message,$arguments,WATCHDOG_INFO) in fontyourface/fontyourface.module on line 674: this is a false positive and doesn't need fixing. All existing calls tofontyourface_log()take the limitations into account;t($data->error) in fontyourface/modules/fontdeck/fontdeck.module on line 40: this is somewhat moot, but probably should be fixed; while there is a finite set of possible error strings and it might make sense to translate them, the problem is you don't get to translate the string before you get the error itself;t($font->name) in fontyourface/modules/fontyourface_ui/fontyourface_ui.module on line 738: this should be fixed. There's no point in translating font names.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | fontyourface-Fix_source_code_warnings_from_localization_system-1713214-2.patch | 2.35 KB | Drave Robber |
Comments
Comment #1
Drave Robber commentedOn a second thought, there's something to 1., too: the way it's done now, strings are picked up for translation when they're first used, not when the code is enabled. This is probably too minor a problem to change the whole setup; however, some documentation for
fontyourface_log()could be useful - just in case some third-party module wants to use the function.Comment #2
Drave Robber commentedPatch attached. (adds some documentation to
fontyourface_log()and fixes 2. and 3.)Comment #3
sreynen commentedLooks good, committed.
Comment #4.0
(not verified) commentedol instead of ul, for easier reference.