Reviewed & tested by the community
Project:
Update Status Advanced Settings
Version:
7.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
4 Aug 2012 at 13:07 UTC
Updated:
28 Nov 2016 at 23:57 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
hass commentedSame here, xou may need to hit save several times until the list is complete.
Comment #2
klonosAs I've previously said here #1418870: Notice: Undefined index: title in theme_update_advanced_settings() in sites/all/modules/update_advanced/includes/settings.inc, this behavior seems to happen every time #512218: Checking for available modules fails for most of the modules occurs (that's a core bug). So, perhaps we should help get that fixed first and then see if this one here persists.
Comment #3
hass commentedThe repro case here is to run update.php and then look on the update_advanced settings page and the table is incomplete. With every page reload the table becomes larger. On large sites you may need to reload 20 times. If you change anything and Save before the table is complete all configuration data get's lost.
Additionally the latest available version is missing in the warn if out of date selectbox.
Comment #4
deanflory commentedI have this happening on two different sites, one with lots of modules installed and one with 30 or so. Clearly it is not accurate at all and appears to show a random amount of modules without those displayed being in alphabetical sequence or anything, just random.
Comment #5
nancydruI have a site in which I have development versions of two of my modules, so I just wanted to stop flagging those. Submitted_By shows up in the list, but Util does not. I have refreshed the page many times and it remains this way.
Comment #6
aohrvetpv commentedCannot reproduce this. All modules are always listed in the table at admin/reports/updates/settings. Perhaps this was fixed by a core change.
Does anyone have reliable steps to reproduce it? I tried #3 but all modules are listed.
Comment #7
hass commentedYou need a large list of modules and themes.
Comment #8
aohrvetpv commentedThanks, hass. Is 50 enough?
Here is what I tried:
1. Installed latest Drupal 7 release.
2. Downloaded the top 50 projects by usage (https://www.drupal.org/project/usage).
3. Downloaded/enabled Update Status Advanced Settings.
4. Browsed to admin/reports/updates/settings. Only 2 projects are shown: Drupal and Update Status Advanced Settings.
5. Checked "Check for updates of disabled modules and themes". Pressed "Save configuration".
6. Verified that page now lists 52 projects (top 50 + Drupal + Update Status Advanced Settings).
Comment #9
aohrvetpv commentedPerhaps there is a timeout that is being reached when this problem occurs. It takes ~10s from the time I press "Save configuration" until the page reloads with the complete list of modules. I imagine this time varies depending on network conditions and the number of projects being checked, and for some sites it could take longer and exceed some timeout before all update checks are completed.
Could someone possibly confirm this is still occurring? I think there may have been some work done to improve the performance of updates checking on either drupal.org or in the Update module, which may have eliminated this problem.
Comment #10
hass commentedYes, it is a timeout. Every module is checked and if this takes a bit longer it times out before all modules have been checked. In this case the list is incomplete. Not sure why you are not able to repro.
Comment #11
aohrvetpv commentedAble to reproduce it now by setting
update_max_fetch_timeto 5. It defaults to 30.So a workaround for this problem may be to set
update_max_fetch_timeto a larger value, like 300.update_max_fetch_timemay not be the only timeout involved, though.Comment #12
aohrvetpv commentedThis patch changes to always list all projects. It uses the change suggested by hass in #1963458-1: Caching does not flush/refresh project data properly. Please review.
Recommended version information may not be available for all projects. This can happen when an updates check is incomplete (e.g. due to the check exceeding
update_max_fetch_timeseconds). The patch handles it by project as follows:The fact that updates checks are sometimes incomplete (and hence there is incomplete recommended version information) is an Update Manager module issue.
Comment #13
aohrvetpv commentedupdate_max_fetch_timewas increased in core from 5 to 30 in May 2014, which probably eliminated this problem for most sites:http://cgit.drupalcode.org/drupal/commit/?id=5a84df0
However, incomplete updates information could still occur under certain conditions, so it is worth changing Update Status Advanced Settings to better handle it. Please review patch in #12.
Comment #14
francewhoaConfirming the patch in comment #12 works. Thanks AohRveTPV :)
We tested that patch with a large site. Which has 136 modules enabled.
During testing we found one remaining bug. But we assumes that that bug is related to the Drupal core Update Manager module not update_advanced? Here are the steps to reproduce that bug:
Write down that module name. For example feeds module
Using