Posted by chx on August 29, 2007 at 11:40am
| Project: | Drupal core |
| Version: | 5.x-dev |
| Component: | theme system |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Simply to fix.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| empty_tbody.patch | 842 bytes | Ignored: Check issue status. | None | None |
Comments
#1
@chx
Tested with:
Your patch worked to remove the empty tbody as advertised. However, if there are no rows in the table (in Calendar module's Prev/Next bar for example), validation still fails. This is because HTML requires that anything that has a thead tags must also have tbody tags. I updated your patch to include a ternary operator to check if there are rows, and if so, add the thead tags.
#2
Looks like the same issue is in Head. Updating the version number to 6.x-dev and adding a patch for Head.
#3
- We don't use /* and */ multiline comments inside code.
- We do use spaces around ? in ternary operators.
Apart from this, this patch obviously only needs some testing, it looks good from here.
#4
Thanks for the review Gábor! Converted mulitline comments into single line // comments. Added the proper spacing to the ternary operator.
#5
ejhildreth, you have to diff from the root install. Here's a proper patch.
The closing /tbody was misplaced so that was corrected. Everything else is pretty much the same from your previous patch.
Tested and validates.
#6
Thanks, committed.
#7
#8
Backporting: This bug is still in DRUPAL-5-dev
#9
#10
Committed to 5.x.
#11
Automatically closed -- issue fixed for two weeks with no activity.