Posted by dju on August 29, 2007 at 12:38pm
Jump to:
| Project: | Image watermark |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | active |
Issue Summary
For example, when GD is missing png support, an error message appears in the watermark configuration page, telling us that the imagepng function does not exist. But actually the function name does not appear, instead we can see the word $function. In the watermark.module file, line 210, the drupal_set_message() function makes use of quotes instead of double quotes, so the $function variable is not replaced in the string.
Comments
#1
"drupal_set_message() function makes use of quotes instead of double quotes, so the $function variable is not replaced in the string."
thx, for the info. that must have happened, when I have optimized the code according to drupal coding standards... because normally we avoid using double quotes. So in this case a concatenation or double quotes should be used.