Node: Node ID missing from view arguments
poolino - August 29, 2007 - 14:22
| Project: | Node comments |
| Version: | 5.x-1.0 |
| Component: | User interface |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
After installing the module I noticed that the option "Node: Node ID" is no longer in the arguments drop down list when adding or modifying a view... is there a specific reason for this? is the module meant to replace this? is there any way to maintain that option with this module enabled? When I disable the module the option appears again.
Thanks
#1
This seems to be because the code in nodecomment_views.inc was creating an array key of 'nid' which was overriding the default provided by the Views module. I changed this to a non-conflicting string (see attached patch file) and it now seems to work again.
Update 2008-01-16: the initial patch caused problems with the view used to display comments. These parameters need to be changed too (included in updated patch file below)
#2
This worked, but I to deactivate then reactivate the Node Comments module.
#3
Looks good to me.
#4
Woah there! I just discovered that my initial patch caused problems with viewing nodes (content would get doubled up). This was because I didn't also update the key used for the default views.
I have re-edited the patch to include this - if you had already integrated the patch, please undo it and use this new version. Thanks.
#5
krew, please not my comments above. You will need to use the new patch on your code instead!
#6
applied to 5.x branch
#7
Automatically closed -- issue fixed for two weeks with no activity.