Right now the xhprof.inc file is being included on every single request even though it may not be necessary. Would be nice if we could remove that require_once and use the logic in xhprof_include() instead.

CommentFileSizeAuthor
#2 XHProf-dont_load_xhprof_inc_unless_necessary-1715426-2.patch765 byteserikwebb

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Note that this also causes conflicts if you have both xhprof and devel modules enabled, and have xhprof profiling enabled for devel, but not for xhprof.module.

erikwebb’s picture

erikwebb commented
Status: Active » Needs review
StatusFileSize
new XHProf-dont_load_xhprof_inc_unless_necessary-1715426-2.patch765 bytes
msonnabaum’s picture

msonnabaum commented
Status: Needs review » Fixed

Patch in #2 doesn't quite work. Can't rely on the return of xhprof_xhprof_enable() to do the include because you may be viewing runs when profiling isn't enabled.

Just committed a similar patch which should work a bit better. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.