In xhprof_shutdown(), the xhprof_shutdown_real() function is blindly added as a shutdown function, even though we may not get a valid XHProf run ID, and therefore nullifies why xhprof_shutdown_real() should run.

CommentFileSizeAuthor
#1 1715432-skip-shutdown-real-if-empty-run-id.patch1.01 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 1715432-skip-shutdown-real-if-empty-run-id.patch1.01 KB

Patch fixes the logic condition in xhprof_shutdown().

msonnabaum’s picture

msonnabaum commented
Status: Needs review » Fixed

Seems legit.

msonnabaum’s picture

msonnabaum commented

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.