I we have one entity referencing from *reference field to the same other entity twice or more thimes, we migrate just one.

Example:
We have node with tags. If we tag the same node with the same term twice we migrate only one, ending up with unmigrated items.

Attached patch fixes it - it changes source key a bit to ensure all of them are migrated.

CommentFileSizeAuthor
#7 1716846_duplicated_referenceces_7.patch3.58 KBslashrsm
#4 duplicated_referenceces_1716846_2.patch3.53 KBslashrsm
#2 duplicated_referenceces.patch1.7 KBslashrsm
duplicated_referenceces.patch1.7 KBslashrsm

Comments

mikran’s picture

mikran commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Tests for this would be good as well.

slashrsm’s picture

slashrsm commented
Status: Needs work » Needs review
StatusFileSize
new duplicated_referenceces.patch1.7 KB

Here they are :)

mikran’s picture

mikran commented
Status: Needs review » Needs work

I think you've uploaded the same patch again

slashrsm’s picture

slashrsm commented
StatusFileSize
new duplicated_referenceces_1716846_2.patch3.53 KB

You are right. Here is the right one.

mikran’s picture

mikran commented
Status: Needs work » Needs review
mikran’s picture

mikran commented
Status: Needs review » Needs work
Issue tags: -Needs tests +Novice

Reroll needed here, the patch didn't apply

slashrsm’s picture

slashrsm commented
Status: Needs work » Needs review
StatusFileSize
new 1716846_duplicated_referenceces_7.patch3.58 KB

Here it is...

mikran’s picture

mikran commented
Status: Needs review » Fixed

Thanks, committed

slashrsm’s picture

slashrsm commented

Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.