Reviewed & tested by the community
Project:
DraggableViews
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
7 Aug 2012 at 09:38 UTC
Updated:
9 Nov 2017 at 21:18 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
mariusal commentedComment #2
joachim commentedPatch works perfectly. Thanks -- just what I was looking for.
Comment #3
joachim commentedAh just one problem: the handler produces error messages if it can't find $row->taxonomy_term_data_weight, which is only there if there's a field/sort/filter on the view that adds it.
So this patch should add documentation about this.
In the longer run, I think handlers should be able to validate the view, or have a say in adding fields to the view -- but that's for another issue.
Comment #4
joachim commentedUpdated patch.
I've added a note of this to the readme and very slightly tidied up the code for coding standards (don't use abbreviations for variable names).
Comment #5
istryker commentedThis patch works. I love how clean this patch is, however, I wonder if #1851752: Drag handler for saving weight into any column in any base table is the better way to go through. This patch does the same thing, however it uses an entity wrapper. I believe there is more possibilities for it.
Comment #6
istryker commentedThird solution added today. This solves taxonomy as a separate submodule. See #1916380: Roadmap to add taxonomy support to module for everything
Comment #7
damienmckennaComment #8
damienmckennaYes, this works perfectly.
Comment #9
abrlam commentedUnfortunately, I'm having trouble patching this (keep getting the new blank line at EOF error). Any pointers?
Thanks.
Comment #10
joseph.olstad@abrlam
try
Comment #11
abrlam commentedThank you @joseph.olstad. It worked.
Comment #12
nwom commentedIt appears the patch no longer works against the newest dev version. Here is a re-roll. Please review.
Comment #13
damienmckennaBack to RTBC.
Comment #14
nwom commentedPlease take a look at #1916168: Taxonomy Term Weight & Hierarchy support submodule. It appears to be more feature complete and works automatically with taxonomy's native weight and hierarchy.
Comment #15
abrlam commentedThank you @NWOM for re-rolling the patch (#12).
On an unrelated note, if you notice draggableview behaving strangely (drag not releasing, getting tabledrag.js relationship error in the console browser), try removing the taxonomy weight field from the Fields section.