Expected behaviour: When you edit sites/default/settings.php and uncomment the line $conf['site_name'] = 'My Drupal site'; and save the file, the site name should change to "My Drupal site."

Actual behaviour: It doesn't. drush cc all doesn't help.

There's a chance this might be 3am syndrome, but I think I double-checked everything.

CommentFileSizeAuthor
#5 conf_sitename-1716920-5.patch549 bytesalbert volkman

Comments

aspilicious’s picture

aspilicious commented

try this:

$conf['system.site']['name'] = 'My Drupal site'

aspilicious’s picture

aspilicious commented
Status: Active » Closed (works as designed)

Tried it myself, it works and we have tests for this ;)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: $conf overrides are not working » $conf override example documentation needs updating
Priority: Critical » Normal
Status: Closed (works as designed) » Active
Issue tags: -Regression +Novice

Oh, well that makes sense. However, there's still a bug here. But now it's normal and novice. :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

You can find this documentation in sites/default/default.settings.php.

albert volkman’s picture

albert volkman commented
Status: Active » Needs review
StatusFileSize
new conf_sitename-1716920-5.patch549 bytes

Here ya go.

aspilicious’s picture

aspilicious commented

I would like to change all the examples once the conversion is done. Most of these will change in the near future.

cobadger’s picture

cobadger commented

I applied the patch, removed the leading hash tag in front of:

$conf['system.site']['name'] = 'My Drupal site';

Cleared caches and reloaded the page; site name did not change and I don't see a row in 'variable' table in db for site name.

Didn't work for me.

jfhovinne’s picture

jfhovinne commented
Status: Needs review » Reviewed & tested by the community

@jordanlgraham: I think you need to apply the patch before installing Drupal.

Applied the patch to current 8.x-dev; installed Drupal; uncommented $conf['system.site']['name'] = 'My Drupal site'; in settings.php; the site name is correctly updated to "Welcome to My Drupal site", so the example is ok.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Postponed

Awesome!

Committed and pushed to 8.x as a stop-gap. Agreed that we're going to need to update this as further conversions take place, however. Probably makes sense to postpone this for now on #1775842: [meta] Convert all variables to state and/or config systems.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue summary: View changes
Status: Postponed » Active
Related issues: +#2167109: Remove Variable subsystem

Ok, so #2167109: Remove Variable subsystem replaced #1775842: [meta] Convert all variables to state and/or config systems so can this be closed or are there further conversions that need to take place?

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Component: config.module » configuration system

If this is still valid, it seems like it is base config system, not Configuration Manager module?

mgifford’s picture

mgifford
he/him
Primary language English
commented
Status: Active » Closed (fixed)

Currently, without the patch it's # $config['system.site']['name'] = 'My Drupal site'; so I'm marking this closed.