Posted by marshmn on August 7, 2012 at 6:40pm
6 followers
Jump to:
| Project: | Project Git instructions |
| Version: | 7.x-1.x-dev |
| Component: | Instructions |
| Category: | bug report |
| Priority: | normal |
| Assigned: | eliza411 |
| Status: | closed (fixed) |
Issue Summary
The information given on the git instrutions page for pushing a tag say:
git checkout 7.x-1.x
git tag 7.x-1.0
git push origin 7.x-1.0However in the guide: Maintaining a drupal.org project with Git (http://drupal.org/node/711070) the instructions are slightly different:
git checkout 7.x-2.x
git tag 7.x-2.0
git push origin tag 7.x-2.0Note the inclusion of the 'tag' keyword in the second example.
I believe that the second version is the correct version? If so then the git instructions should be updated to this.
Comments
#1
Both are technically correct. However the second is more specific, and slightly safer.
So +1 to change the instructions.
#2
eliza411: What's your take on this?
#3
This is a newly introduced syntax. sdboyer and I would like to know when it was introduced in git before updating.
#4
The documentation of this 'feature' in Documenation/git-push.txt was added in 2009 and is included in v1.6.1.3 by commit 803918462e58005d18c0ab63686dbd9e91330dfe.
When the actual feature was added will be somewhat harder to dig out.
#5
I think that's plenty :) I'll confirm with sdboyer, then make the update.
#6
sure, that's plenty old enough. i'm fine with updating the docs to suit.
#7
I've made this change. Sorry it took so long to get to and especially since the syntax turned out to be older than sdboyer originally thought :)
#8
Automatically closed -- issue fixed for 2 weeks with no activity.