The other day we were testing custom filters on a search page, and it was pretty annoying that every time we saved the form it redirected us back to the environment overview page. Adding a "Save and Edit" button would make tasks like this a lot simpler by allowing search administrators to save and test changes more easily.

CommentFileSizeAuthor
#12 1717628-12.patch4.59 KBnick_vh
#10 1717628-10.patch1.08 KBpwolanin
#7 1717628-7.patch1.52 KBnick_vh
#3 1717628-3.patch2.75 KBnick_vh
#2 1717628-2.patch2.99 KBnick_vh

Comments

soyarma’s picture

soyarma commented

+1000

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Active » Needs review
StatusFileSize
new 1717628-2.patch2.99 KB

Adds some duplicate code for path redirect, but it works as expected. On a save it gets returned to the admin page with the listing. On safe and edit it returns the the current_path, whatever that might be.

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
StatusFileSize
new 1717628-3.patch2.75 KB

stupid whitespaces

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Version: 7.x-1.x-dev » 6.x-3.x-dev
Status: Needs review » Patch (to be ported)

Committed to 7.x-1.x, needs backport

cpliakas’s picture

cpliakas commented

Totally awesome! Great work.

pwolanin’s picture

pwolanin commented

I'm seeing the normal "save" as broken now in 7.x - it keeps me on the same page.

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Version: 6.x-3.x-dev » 7.x-1.x-dev
Status: Patch (to be ported) » Needs review
StatusFileSize
new 1717628-7.patch1.52 KB
nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Version: 7.x-1.x-dev » 6.x-3.x-dev
Status: Needs review » Patch (to be ported)

Committed to D7, moving back to needs backport for 6.x-3.x

pwolanin’s picture

pwolanin commented
Version: 6.x-3.x-dev » 7.x-1.x-dev
Status: Patch (to be ported) » Needs work

'op' is deprecated.

pwolanin’s picture

pwolanin commented
Status: Needs work » Needs review
StatusFileSize
new 1717628-10.patch1.08 KB

how about this?

pwolanin’s picture

pwolanin commented
Version: 7.x-1.x-dev » 6.x-3.x-dev
Status: Needs review » Patch (to be ported)

committed to 7.x

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 1717628-12.patch4.59 KB

backported to 6.x-3.x - that destination param is a sh*t thing in D6. Patch I posted has been manually and programmatically tested.

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Needs review » Fixed

committed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.