When the geofield is not required if the user does not fill an input geofields assumes (with #1717388-7: Empty values in Lat/lng and Bounds widgets does not work) the field is empty without warning the user.

This patch adds that validation to alert users that in case the fill one of the input they must fill the rest.

CommentFileSizeAuthor
#4 1717860-4-am.patch2.58 KBjherencia
#4 1717860-4.patch2.14 KBjherencia
#1 1717860-1-am.patch2.82 KBjherencia
#1 1717860-1.patch2.39 KBjherencia
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jherencia’s picture

jherencia CreditAttribution: jherencia commented
FileSize
1717860-1.patch2.39 KB
1717860-1-am.patch2.82 KB
phayes’s picture

phayes CreditAttribution: phayes commented

We need to be careful about the use of using empty function where we are dealing with float values that may (correctly) be "0.00"

jherencia’s picture

jherencia CreditAttribution: jherencia commented
Assigned: Unassigned » jherencia
Status: Needs review » Needs work

Again, you are right.

jherencia’s picture

jherencia CreditAttribution: jherencia commented
Status: Needs work » Needs review
FileSize
1717860-4.patch2.14 KB
1717860-4-am.patch2.58 KB
Brandonian’s picture

Brandonian CreditAttribution: Brandonian commented
Status: Needs review » Fixed

Looks good, @jherencia. Committed.

http://drupalcode.org/project/geofield.git/commit/7cc6aca

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.