Enabling/disabling metatags for custom entities and bundles no longer works since 7.x-1.0-alpha7 because now metatag_entity_has_metatags($entity_type, $entity) can return TRUE for an entity for which metatag_entity_supports_metatags($entity_type, $bundle) returns FALSE.
I'm attaching a patch that makes the module respect its own metatag_entity_supports_metatags() function again.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | metatags-disableable-testonly-1718594-7.patch | 2.31 KB | JvE |
| #7 | metatags-disableable-combined-1718594-7.patch | 2.91 KB | JvE |
| #5 | metatags-disableable-testonly-1718594-5.patch | 2.44 KB | JvE |
| #5 | metatags-disableable-combined-1718594-5.patch | 3.17 KB | JvE |
| metatags-disableable.patch | 610 bytes | JvE |
Comments
Comment #1
jax commentedMarking this as a dupe of #1371968: Show/Hide Meta tags fieldset per content type.
Comment #2
JvE commentedRe-opening since this issue is about the bug that metatag_entity_has_metatags($entity_type, $entity) can return TRUE for an entity for which metatag_entity_supports_metatags($entity_type, $bundle) returns FALSE.
Not about controlling Meta tags per content type.
Comment #3
damienmckennaNeeds to be rerolled, but I think this will be worthwhile.
Comment #4
damienmckennaTag.
Comment #5
JvE commentedI updated the test and rerolled the patch.
Changes to the test:
- removed invalid cases that should (and will) throw exceptions in core entity handling.
- changed testing metatag_entity_supports_metatags to testing metatag_entity_has_metatags since the actual module functionally uses the latter.
Changes to the module:
- entities can no longer "have" metatags if their entity-type/bundle does not support them (or they have been disabled).
Comment #7
JvE commentedSigh..
Comment #8
damienmckennaWill be reviewed next.
Comment #9
damienmckennaCommitted! Thanks JvE!
Comment #10
damienmckennaLast night saw the release of 7.x-1.0-beta1, so I'm closing all these "fixed" issues in the interest of tidying up the issue queue. Thank you all for your help getting us to this point!
Comment #10.0
damienmckennaUpdated issue summary to clarify the bug and avoid confusion.
Comment #11
damienmckenna