Hi!
I use facet api with apachesolr. I have set the facets to display in all node pages (node/*)
Some of my node pages have a path alias set and some do not. The facets are displayed *only* for the pages that do not have the path alias set.
The expected dehaviour would be to display for all node pages no matter the path alias.

This happens because only the alias path is checked and not the original path.

Comments

msti’s picture

This is a patch to fix it

nick_vh’s picture

Status: Active » Needs review
StatusFileSize
new2.71 KB

Some improvement, but it certainly makes sense what you try to do there.
moved the check to not load this function if facetapi is not available to the beginning of the process. No need to load a search page if that is not available.

perhaps we want to remove the load search pages thing or make that more performant. Looking into it

Status: Needs review » Needs work

The last submitted patch, 1719302-2.patch, failed testing.

nick_vh’s picture

Status: Needs work » Needs review
StatusFileSize
new6.08 KB

Great, so this improves the loading of search pages from three times per page load to once max per page load.
We probably do want to reduce this, because loading it on every page load is not something I find very acceptable if the checkbox for getting facets on every search page is not selected.

Status: Needs review » Needs work

The last submitted patch, 1719302-3.patch, failed testing.

nick_vh’s picture

StatusFileSize
new8.22 KB
nick_vh’s picture

Version: 7.x-1.0-rc2 » 7.x-1.x-dev
Status: Needs work » Needs review
nick_vh’s picture

Version: 7.x-1.x-dev » 6.x-3.x-dev
Status: Needs review » Patch (to be ported)

Committed (fixed the end of file error before committing) to D7

Thanks for reporting!

msti’s picture

I am glad to help!

nick_vh’s picture

Status: Patch (to be ported) » Needs review
StatusFileSize
new8.29 KB

Backported

nick_vh’s picture

StatusFileSize
new8.27 KB

newline added

Status: Needs review » Needs work

The last submitted patch, 1719302-11.patch, failed testing.

nick_vh’s picture

Status: Needs work » Needs review
StatusFileSize
new8.31 KB
nick_vh’s picture

Status: Needs review » Fixed

committed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.