First, thanks for your work on this!
Problem/Motivation
I stumbled across a small bug that Panopoly will show all layouts, regardless of those selected, with Panelizer layouts settings in place, even.
However, Panelizer itself shows only the layouts you select, for each content type, if one were to edit the layout of a node on the Panelizer page.
Proposed resolution
Allow the Panopoly-specific layout category options to mimic Panelizer's. Please only display what has been selected in the Panelizer layout settings.
Thanks for your hard work!
jtreinau
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 1719372-fix-extra-allowed-content-tab.patch | 3.12 KB | merlinofchaos |
Comments
Comment #1
populist commentedGlad you liked Panopoly!
I did some investigation of your issue and believe I got to the bottom of it. Basically, Panelizer has *two* different settings for layouts for individual node pages. They can be seen in Panopoly Pages at the following paths:
OPTION ONE - admin/config/content/panelizer/node/panopoly_page/allowed (you get here by clicking "allowed content" next to the node type)
OPTION TWO - admin/config/content/panelizer/node/panopoly_page.page_manager (you get here by clicking "settings" next to the view mode and then "available content")
As it turns out, only OPTION ONE actually has an effect of allowing you to select the layout. OPTION TWO does nothing! I am going to move this over to the Panelizer queue for additional feedback, but thats generally my gut on what is going on.
Comment #2
jeremiahtre.in commentedRight on, thanks for doing that! I remember messing around with page manager settings and thinking "hmmph".
So, this would be affecting Panopoly's modal window, where you change the layout? I think we're on the same page that I'm seeing all the layouts, instead of seeing specific ones (desired)? Ive been setting the layouts up through Option 1.
i.e. ../panels/ajax/ipe/change_layout/panelizer:node:13
Thanks a 'mil!
jtreinau
Comment #3
populist commentedAs it turns out, there happens to be a number of different "Allowed Content" options being surfaced in Panelizer (see #1 for details). What needs to happen, I think, is that per view mode "Allowed Content option" (admin/config/content/panelizer/node/panopoly_page.page_manager) needs to be removed.
Comment #4
merlinofchaos commentedOkay, this patch seems to fix the issue. Plus, it improves the title on the settings pages to include information about what entity + bundle + view mode is actually being edited.
Comment #5
populist commentedI reviewed and tested this patch today and it works great. The extra tabs were removed and the exporting of Panelizer settings through features/strongarm still works as expected.
Comment #6
merlinofchaos commentedThanks for the test! Committed and pushed.
Comment #7
jeremiahtre.in commentedAwesome, can't wait to try this out! Thanks so much for working on this. @populist, looking like a beta7 inclusion, or maybe a 1.0 release (getting closer!)?.
jtreinau
Comment #8
mrfelton commentedThis is just not working for me at all. The checkboxes still do nothing.
From /admin/config/content/panelizer I can click on the Allowed content link for one of my content types. It takes me to /admin/config/content/panelizer/node/cw_page/allowed. On that page there are vertical tabs for 'New content behavior' and a whole bunch of other 'NBew content for x' tabs. None of the checkbxes on any of these tabs do anything at all. I can uncheck them, save the page, and it just reloads with all of them checked again.
By reading around the threads, I also found I could access this at /admin/config/content/panelizer/node/cw_page.page_manager/allowed. The checkboxes on this page DO work (as in, they save their value and don't just always show as being checked), although they still have no effect on the actual allowed content types that are presented to the user when editing a panelized node.
Comment #9
merlinofchaos commented#8: I can't duplicate that behavior. I did find that the 'cw_page.page_manager' version of the page was available, but that page is non-functional.
When I tested the normal version of the page, I found that the checkboxes work correctly and as advertised. I'm not entirely certain what the problem might be. I did commit a test to make the non-functional view-mode specific version of the page inaccessible, at least.
Comment #10
mrfelton commentedOk, so at least I can't access the other version of this page. But, still the version that I can access is non-functional. This time, with a completely different site, latest panelizer 3.1, at the url /admin/config/content/panelizer/node/page/allowed which is the allowed content settings page for the 'Full page override' mode. Unchecking checkboxes and saving the form does nothing. The checkboxes revert to how they were, as if I had done nothing. Not one of the hundres f checkboxes on that page can be unchecked.
Comment #11
mrfelton commentedHere is how I got it working.
In my case, the key to getting this fixed was to run
delete from variable where name like 'panelizer%';. I had upgraded from an earlier version, and there were 27 variables related to panelizer that had been set (reinstalling the module using /devel/reinstall did not delete these variables). After doing that, my settings page at /admin/config/content/panelizer looked a little different, and now it works!But, only because I ditched using the 'Full page override' mode, and instead set my page content type up to use custom display settings for the Full view mode, and then configured Panelizer on the Full view mode.
Neither using the Default or Full page override view modes worked. But using the Full view mode did.
Comment #11.0
mrfelton commentedtag for sig
Comment #12
damienmckennaIt has been two years since this was last updated, can someone please let me know if the problem persists?
Comment #13
damienmckennaJust going to close it, but please reopen it if the problem persists. Thank you.