Posted by dvessel on August 30, 2007 at 11:53pm
3 followers
Jump to:
| Project: | Drupal core |
| Version: | 6.x-dev |
| Component: | theme system |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
This fixes two issues related to account specific themes.
One is the description for the theme select form when editing your account. When none is ever selected, it presents a "2". That goes away after setting your theme but then the description never appears. Not sure how Drupal 5 was doing it but the arguments in "system_theme_select_form()" is setup the same way and it works fine. This patch removes the first argument "&$form_state".
The other is an notice do to a bad check inside init_theme().
notice: Undefined index: 2 in /Users/joon/Sites/projects/DRUPAL-HEAD/includes/theme.inc on line 44.
notice: Trying to get property of non-object in /Users/joon/Sites/projects/DRUPAL-HEAD/includes/theme.inc on line 44.| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| account_theme_1.patch | 1.55 KB | Ignored: Check issue status. | None | None |
Comments
#1
#2
Applies with a small offset. Fixes the two issues mentioned, and also fixes a third issue: the previously selected theme was not selected by default in the form, so saving the form without explicitly selecting a theme would always switch you back to the default theme.
#3
Great, thanks!
#4