Closed (outdated)
Project:
Drupal core
Version:
6.x-dev
Component:
Garland theme
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
31 Aug 2007 at 00:01 UTC
Updated:
2 Mar 2016 at 22:18 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jrabeemer commentedUpdate:
The problem stems from how IE treats the tag with a large vertical height. This is an IE7 CSS bug as far as I can tell. All the other browsers treat the tag with normal height and thus don't show the bug. I have created a patch against D6 Head that adds a fix-ie7.css file to the Garland theme. This was necessary since the fix specifically targets IE7 or greater and if it were added to the base style.css file, it causes spacing problems with other browsers. The change also fixes the sub Minelli theme.
The fix is documented here:
http://www.mattheerema.com/archive/getting-fieldset-backgrounds-and-lege...
Tested against IE7, Safari 3.03, Opera 9.23, and FF 2.0.0.6. It doesn't affect other browsers since the fix uses an IE conditional.
Side effect:
Spacing below the tag is tighter since the tag is forced upward with the top: attribute. It doesn't affect readability though.
IE Testing would be much appreciated!
Comment #2
jrabeemer commentedAttached a screenshot of what my fix looks like in IE7.
Comment #3
jrabeemer commented-Forgot to add $Id$ tag.
-Added a note to file to reference back to this bug
Comment #4
ChrisKennedy commentedSpacing inside of the fieldset can be fixed by adding: padding-top: 2em to the fieldset CSS in fix-ie7.css
Otherwise it works for me. But I think the name attribution should be removed unless you have a specific reason for including it. We don't do this in Drupal and it would quickly bloat the source code if it became standard practice.
Comment #5
jrabeemer commentedNo problem. Updated patch.
-Removed reference..
-Added padding-top: 2.5em;
Comment #6
jrabeemer commentedI'd appreciate any core committers with IE7 installed to test. Attached a new screenshot with padding added from previous patch. The output is now nearly identical to FF/Safari.
Comment #7
jrabeemer commentedIf no one objects, this is ready to commit.
Comment #8
dvessel commentedUnless it's a really trivial, you shouldn't RTBC your own patch.
I'll review and provide a patch as soon as I get IE7 installed. I don't think the current patch is the way to go. What happens when the text size is changed? Your use of absolute positioning and negative margins in em's looks like it would turn out unpredictable results. Instead, it should all flow as relative position.
Comment #9
jrabeemer commentedFYI, in IE7 unlike IE6, scaling of fonts is relative to overall size. If you zoom with keyboard shortcuts CTRL + - or CTRL + -, the page scales proportionate. If you set text size Largest or Smallest, there's no change in IE7 with garland. If you try to set both, everything is still proportionate.
Comment #10
jrabeemer commentedHere's a screenshot at 150% zoom and text size set to Largest. Looks ok.
Comment #11
jrabeemer commentedHere's at the other end, 50% zoom out and text size set to smallest. Looks ok.
Comment #12
jrabeemer commentedIE6 and 7 have space around the legend element that doesn't seem to follow margin or padding rules around it. Using position: absolute; is to bring the element out of the flow. The link given in #1 describes the problem.
Comment #13
jrabeemer commentedHere's another screenshot of IE7 under Windows XP. IE7 at 150% zoom with text set to largest. No change.
Comment #14
dvessel commentedThat looks good. I already rolled a patch that fixes it another way and uses a css selector hack. Doesn't cause any validation errors though. Generally not the best way to go but I figured, it's for a single rule.
That's all that was addded.
Comment #15
jrabeemer commentedThat's pretty good. I made some fixes. I've restored the blue lines that have the descender arrows. Fixed the header bg spacing was off a minor bit when zoomed. Fixed the padding around the legend tags and description paragraphs below that didn't match other browsers.
Comment #16
jrabeemer commentedFound another small bug. A white background color was visible at the topmost box. You can see it against a gradient. Fixed.
Comment #17
dvessel commentedThis works, and once we have enough of IE7 specific issues it would be easy to search for these selectors and move them into their own style sheet.
Comment #18
gábor hojtsyAgreed. Thanks for the patch, committed.
Comment #19
(not verified) commentedComment #20
alan d. commentedSorry for recycling the issue, but here was another D6 fieldset issue found on IE8 in compatibility mode in XP sp3 (x32). It effects the D7 version in both IE8 strict and compatibility modes.
The autocomplete within a fieldset drops below the fieldset legend of any other fieldsets that are below, as seen in the attached screenshot. My initial attempts failed to find a solution but I'm not a CSS hacker :(
The quick hack to produce the autocomplete in the fresh D7 install was to cut and paste the taxonomy autocomplete into the reports section, code pasted below and screenshot attached. To replicate this in D6, free tagging taxonomy produces the error when free tagging vocab autocompletes drop over the menu fieldset below.
This issue was pointed out in the taxiselect issue queue (another issue), and the reporter posted this video of the bug: http://www.youtube.com/watch?v=whZFHIKKY4E
Comment #21
alan d. commentedAnother issue for the seven theme has a very similar issue for the autocomplete background with the same setup: http://drupal.org/node/539724#comment-1919596
Comment #22
extensive commenteddownload fresh file of and replace with below
misc/jquery.js update