Hi!

I installed you module right now (it looks great), but after enabling, I have hundreds these messages in my watchdog

Missing argument 4 for dot_disclaimer_user() in
/home/somvprahe.sk/somvprahe.sk/www/sites/all/modules/dot_disclaimer/dot_disclaimer.module on line 196.

I have enabled dot just for comments for now.
Thanks
Igor
somvprahe.sk

CommentFileSizeAuthor
#1 dot_disclaimer-171967.patch15.14 KBregx

Comments

regx’s picture

regx commented
Status: Active » Needs review
StatusFileSize
new dot_disclaimer-171967.patch15.14 KB

let me know if this fixes the problem for you.

igorik’s picture

igorik commented

yes, it helps, thanks.

anyway, I found that this feature thar user have to check checkbox for post comment is really unpopular,
so finally I add this line into comment.module (line 1566)
$form['agreement'] = array('#type' => 'checkbox', '#title' => 'By posting this comment you agree with terms and contitions for posting comments on our site', '#disabled' => TRUE ,'#value' => 1 , '#weight' => 19);

so there can be interesting feature request to let admin that checkbox checked by default and to set message for it.

igor

regx’s picture

regx commented

If you don't put any text into the checkbox text, then the node will be displayed without the checkbox.

igorik’s picture

igorik commented

Hi

I am not sure which node you mean - This checkbox is shown inside comment form with it's title form properly.
In published comment there is this checkbox useless, it's (information) value is in comment form only.

Thanks for answer
Igor

regx’s picture

regx commented

In the required text box in admin/settings/dot_Disclaimer if you delete the required text, then no checkbox will be displayed, just the disclaimer.

regx’s picture

regx commented
Status: Needs review » Fixed
Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)
shmatty29’s picture

shmatty29 commented

hi, when applying this patch I get

Hunk #1 failed at 1.
1 out of 1 Hunk failed -- saving 1 rejects to file dot_diclaimer.module.rej

i am relatively new to patching, am i doing something wrong?

thanks, matt

shepherdjack77’s picture

shepherdjack77 commented

Hi,

I was just wondering if you could advise me on using this patch, I have just tried replacing the code in the .module file with the code in the patch (excluding the text that isn't php at the start) but this just brings up the error "Parse error: syntax error, unexpected T_FUNCTION in C:\wamp\www\lakelandroutes\sites\all\modules\dot_disclaimer\dot_disclaimer.module on line 212"

Thanks,

Jack

scoutbaker’s picture

scoutbaker commented

This patch is included in the 5.x-1.x-dev version of the module already.