Closed (fixed)
Project:
Automatic Nodetitles
Version:
7.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
9 Aug 2012 at 02:00 UTC
Updated:
13 Apr 2018 at 18:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jherencia commentedComment #2
bojanz commentedThis doesn't look right.
Seems to me that this module should implement hook_inline_entity_form_entity_form_alter() besides the usual alter, so that IEF is covered as well.
Comment #3
jherencia commentedOk, here is a new attempt :).
Comment #4
bojanz commented+ $entity_form['title']['#value'] = 'ant';
Huh?
Comment #5
jherencia commentedhttp://drupalcode.org/project/auto_nodetitle.git/blame/HEAD:/auto_nodeti...
It's in right now, but I haven't analyze the code enough so do not know why either.
Comment #6
marvil07 commentedAfter a black-box test on the patch at #3 it seems to work fine.
Comment #7
imclean commented#3 works for me as well, thanks.
Comment #8
froboyNode title is required on submission, so I'm assuming that this is just assigning an arbitrary string to #value so that it can be generated later.
Also, this seems to have tested well, so any chance of getting it committed?
Comment #9
dww+1 that #3 is RTBC.
Tested and it solves the problem.
Reviewed the code and found no objections. I thought it was a shame that it sort of duplicates so much of
auto_nodetitle_form_node_form_alter()but they're both small functions and enough details are different that trying to merge them is going to make the code worse.Inline Entity Form is becoming the defacto standard for solving the problem of creating new entities for an entity_reference field in D7. I think it's worth it for auto_nodetitle to add this extra code to properly support that module.
Thanks!
-Derek
Comment #10
-enzo- commentedI tested the patch #1719948-3: Integration with inline entity form and works perfectly, please apply in next release
Comment #11
_vid commentedConfirming patch #1719948-3 applies cleanly to both 7.x-1.x-dev and 7.x-1.0. Thanks all for working on this.
Comment #11.0
_vid commentedChange hook to implement.
Comment #12
strykaizerI altered patch in #3 to ensure this patch is also working when the title module is active (which replaces the title field).
Changes attached
Comment #13
strykaizerIgnore #12, uploaded new file which fixes the title module too in inline entity forms.
Comment #14
mariusm commentedI can not apply patch 1719948-13.patch
"The chunk size did not match the number of added/removed lines"
I change
@@ -39,6 +39,25 @@ function with
@@ -39,6 +39,34 @@ function
Comment #15
vadym.kononenko commented#13 patch is malformed.
I've fixed it as it was described in #14 (https://drupal.org/comment/8187367#comment-8187367).
Updated file was attached.
Comment #16
JMC commented#15 patch works for me on 7.x-1.x-dev, thanks!
Comment #17
potassiumchloride commented#15 works for me on 7.x-1.x-dev. Thank you so much!
Comment #18
aytee commentedPatch #15 worked for me. Just what I needed. Thanks!
Comment #19
tsi commented+1
#15 works for me too
Comment #20
rcodinaPatch #15 works for mee too! Please, do a 2015 release of this module with this. Current stable release is from 2011, too old!
Thanks!
Comment #21
feldmarv commented#15 works for me on 7.x-1.x-dev. GREAT!
Comment #22
skribbz14 commented#15 worked great, thanks!
Comment #23
bigjim commentedJust piling on here, #15 worked for me
Comment #24
wOOge commented#15 worked for me as well.
Looks like this has been reviewed by others and work — how can we get this added to a -dev release now?
Comment #25
pianomansam commented+1 for #15 being RTBC. Let's get this committed!
Comment #26
rcodinaPlease, commit this and create a fresh 2015 release!
Comment #27
rcodinaComment #28
rcodinaComment #29
tamerzg commentedWe need this released!
Comment #30
cvharris commented#15 works for me too! Merge this sucker in!
Comment #31
thejimbirch commentedI know this is now an unsupported module, but the patch in #15 worked for me also.
Comment #32
biigniick commented#15 no longer works for me
Comment #33
potassiumchloride commented#15 applied to newest -dev branch and solved the issue with hiding titles for nodes created via inline entity form.
Comment #35
gaurav.kapoor commentedThank you all for working on this issue.
Comment #36
gaurav.kapoor commentedComment #37
gaurav.kapoor commented