Haudi.

I have several bugs to report, I hope it won't be a problem reporting them all here, for a start.

1. By activating the module, functionalities (I suppose jquery functionalities) stop working. Example: Coming from some permission modules (I do not know exactly which permission module it is), I have the possibility to choose for each field how the permissions for this field look like (see image 1). There is a 'Custom Permission', which activated, opens a permission table. This table does not open any more after activating the "field conditional state" module.

2. I have a collection field with several fields. I allow more than one value collection for the collection field. Using "field conditional state" on this field works fine for the first value collection, but adding a second value-collection (i.e. a second field collection), the "field conditional state" does not act on the fields of this second (and additional) collection field. In the example of image 3 the fields "New Version" & "Old Version" schould only appear when "edited field" is set to a certain value. This works fine for the first set of fields, but the second set of fields "New Version" & "Old Version" appear without having choosen any value for "edited field". In other words: "field conditional state" does not work for any additional added item.

I hope these infos help further development of this very fine module (I cannot use for the moment due to these problems)

Cheers

CommentFileSizeAuthor
#9 field_conditional_state-1720120-9.patch789 bytesryan.gibson
#8 no-js-on-field-edit-form-1720120-6.patch771 bytesdflitner
3.jpg46.93 KBPatribus
2.jpg45.41 KBPatribus
1.jpg87.64 KBPatribus
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

frikovc’s picture

frikovc CreditAttribution: frikovc commented

+1
Have the same problem. Happens with field permission module.

kaizerking’s picture

kaizerking CreditAttribution: kaizerking commented

Thanks for posting , My site crashed with PDO exceptions when i enable this module. I am also usingthe field permissions module

vishy_singhal’s picture

vishy_singhal CreditAttribution: vishy_singhal commented

My autocomplete and other jquery features stopped once I used this. Just to add - I am using your module along with FieldGroup

dflitner’s picture

dflitner CreditAttribution: dflitner commented

Issue 1 occurs for me as well using Field Conditional State plus Field Permissions. Here's a discussion in the Field Permissions issue queue with a similar problem regarding LoginToboggan.

balumba’s picture

balumba CreditAttribution: balumba commented

Same problem here with the field_permissions module

balumba’s picture

balumba CreditAttribution: balumba commented
Status: Active » Needs review

Here is a fix:

In file /sites/all/modules/field-conditional-state/field_conditional_state.module

Change line 171 from 

if (isset($element['#field_name']) && isset($element['#bundle'])) {

to 

if (isset($element['#field_name']) && isset($element['#bundle']) && $form['#form_id'] != 'field_ui_field_edit_form') {

The field-conditional-state javascripts will not be included in the field_ui_field_edit_form form anymore and field_permissions settings reappear.

Sorry I don't know how to create this as a patch or something.

dflitner’s picture

dflitner CreditAttribution: dflitner commented

#6 is working for me. Will try to roll a patch tomorrow unless someone beats me to it :)

dflitner’s picture

dflitner CreditAttribution: dflitner commented
FileSize
no-js-on-field-edit-form-1720120-6.patch771 bytes

I hope this works.

ryan.gibson’s picture

ryan.gibson CreditAttribution: ryan.gibson commented
Status: Needs review » Reviewed & tested by the community
FileSize
field_conditional_state-1720120-9.patch789 bytes

This fix worked for me. Here's the reroll. I believe it's ready to be committed.

Tobias Xy’s picture

Tobias Xy CreditAttribution: Tobias Xy commented
Version: 7.x-1.0 » 7.x-1.x-dev
Status: Reviewed & tested by the community » Fixed

Works for me too => Committed.
The patch only fixes problem 1, but the second problem should be fixed anyway, in the development version.

cornelyus’s picture

cornelyus CreditAttribution: cornelyus commented

Thanks a lot for the patch!

Incredibly I downloaded this module 3 days ago, on the 7th, and the version from the 8th corrected this issue!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.