There is minor issue with position of * when we drag&drop entities in ief. It breaks arrows position too, so the nice flow is broken. It looks like css form ief is a culprit.

ief - ui minor issue

CommentFileSizeAuthor
#3 ief_tabledrag_handle_styling-1720368-3.patch668 bytesvasike
#1 inline_entity_form-css_cleanup-1720368-1.patch420 bytesmarcin.wosinek
ief - ui minor issue.png15.44 KBmarcin.wosinek

Comments

marcin.wosinek’s picture

marcin.wosinek commented
Status: Active » Needs review
StatusFileSize
new inline_entity_form-css_cleanup-1720368-1.patch420 bytes

Patch.

bojanz’s picture

bojanz commented
Status: Needs review » Needs work

Makes it look really broken in Kickstart:
http://www.evernote.com/shard/s225/sh/3629e7b5-d58e-4975-8200-02cde57eb3...

(Might just mean that the Kickstart admin theme needs an update, but it's something that will have to wait in any case)

vasike’s picture

vasike
Location Ramnicu Valcea
commented
Status: Needs work » Needs review
StatusFileSize
new ief_tabledrag_handle_styling-1720368-3.patch668 bytes

indeed in Kickstart won't work the previous solution because the Shiny theme use the CSS "border-box" model.
So what can it be done here it's to use this model for this table cell and its elements.
This means it should be positioned (same dimensions) the same, no matter of the theme, except the theme that overrides these CSS definitions.

here is patch that brings this solution.
it worked for all (11) themes present in Commerce Kickstart.

chris matthews’s picture

chris matthews commented
Issue summary: View changes

The 5 year old patch in #3 to inline_entity_form.css applied cleanly to the latest inline_entity_form 7.x-1.x-dev and if still applicable needs review.

Checking patch theme/inline_entity_form.css...
Hunk #1 succeeded at 15 (offset 4 lines).
Applied patch theme/inline_entity_form.css cleanly.
bluegeek9’s picture

bluegeek9 commented
Status: Needs review » Closed (outdated)

We appreciate your contributions to Inline Entity Form. Drupal 7 in End-of-Life. We encourage you to upgrade to a supported version of Drupal.

//www.flaticon.com/free-icons/thank-you Thank you for your contribution! Your continued support makes this project sustainable.
There are multiple ways to show appreciation for the work contributed to this project including:

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.