Closed (fixed)
Project:
FeedAPI
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
31 Aug 2007 at 16:05 UTC
Updated:
20 Nov 2007 at 10:27 UTC
Jump to comment: Most recent file
I'm tried to use version 0.3, 1.x-dev, and cvs version of FeedApi and aways have the same error:
This feed () doesn't have any processor. It's not possible to refresh the feed.
When I edit the article the feed url as just gone.
help needed.
| Comment | File | Size | Author |
|---|---|---|---|
| #23 | update_0.diff | 2.44 KB | xpete |
| #2 | variables.sql__0.txt | 94.25 KB | xpete |
Comments
Comment #1
aron novakxpete, it sounds like a bug.
Can you tell me more details about it?
I'm interested in the following:
- PHP 4 / 5?
- exact list of all the enabled modules in the Drupal site where you use FeedAPI
- can you attach a dump of variable and FeedAPI's own table SQL dump?
- when you installed FeedAPI did you do the things according to the INSTALL.txt ?
Thanks for the report.
Comment #2
xpete commentedtested in php 4 and 5.
Modules
DB Maintenance
highlight
Blog
Book
Comment
Contact
Locale
Menu
Path
Poll
Profile
Search
Statistics
Taxonomy
Throttle
Tracker
Upload
Coder
FeedAPI
FeedAPI Item
SimplePie parser
Image
Upload image
SpamSpan
GMap
Location
Invite
Mass Contact
Blogger
Admin Block
Admin RSS
AdvancedMenu
Archive
Atom
BlockRegion
Comment RSS
DHTML Menus
Favorite Nodes
Form collect
Form store
Google Analytics
XML Sitemap
Janode
Live Search
LoginToboggan
MyCaptcha
Ohloh
OpenID
Printer-friendly pages
Release Monitor
Search 404
Search config
Similar entries
Site map
Tabbed Block
Taxonomy DHTML
TinyMCE
Token
Update status
Upload preview
Usernodes
Views Alpha Pager
Project
Project releases
Smileys
Buddylist
Buddylist Invite
Syndication
Userpoints
Userpoints Basic
Views
Views RSS
Views Theme Wizard
Views UI
Fivestar
Voting API
and some done by myself
Project extras
Menu Projectos
Release extras
FeedApi table are empty but should not.
variables atached
What INSTALL.txt?
I've followed instructions on your screencast.
I'm using the content type created by the project module to create the feed, so i can have 1 feed per each project.
the content type for feed items is "story".
Comment #3
aron novakThanks for the fast response.
I see that your environment is rather complex with tons of module. Here at my dev environment it's an enormous work to reproduce. Can you try out the FeedAPI in your environment and as you did it earlier but without the 3rd party modules?
Or (my guess) is that the problem maybe with the conflict of feedapi and project - can you try it out without the Project module?
Last: And the most important: which URL have you tried to supply into the form? Can you paste here one that you tried and failed? I assume you tried it with various feed URLs.
Comment #4
xpete commentedrss links:
http://sourceforge.net/export/rss2_projnews.php?group_id=90363&rss_fullt...
http://sourceforge.net/export/rss2_projnews.php?group_id=65438&rss_fullt...
http://sourceforge.net/export/rss2_projnews.php?group_id=148885&rss_full...
http://irrepupavel.blogspot.com/feeds/posts/default/-/serpentine
A will make some tests width the project module later.
I thinks It also ignores the option to only show a simple form width only one input.
Comment #5
Souvent22 commentedWhich version of MySQL are you guys using, and could you place the "SHOW CREATE TABLE" of the feedapi table here?
I think I may know what it is, but want to be sure this is the problem that you guys are having.
See, if there is an error during creation, and nothing gets put into the feedapi table, the URL will always be gone because FeedAPI only does an UPDATE DML statement, and doesn't insert again. Thus, it will try and update something that doesn't exists, and you will never have a url there.
If this is the issue, there is a quick fix to it.
Also, during the creation, the "settings" field is set to "NOT NULL", but doens't have a default value. But, on the first creation, the settings field is not set, thus mysql throws an error, and nothing goes into the table. And thus, see the above statement about updating something that does not exist. :).
Comment #6
xpete commentedI've done a new instalation of drupal 5.2, project, FeedAPI 5.x-1.x-dev, 'FeedAPI Item', and 'SimplePie parser' using MySQL 5.0.26.
I've enable feed content type for project and tried to create a new project filling all mandatory including the feed URL and I've got this message "Enter a URL" that should be "Enter a feed URL". This message should not apear and would be good to have a option to choose if want that field to be mandatory.
Then i've created a new content type only for feeds and enable the feed content type but when i re-edit the content type the feed option is disabled.
I've seen that you've updated the CVS but i haven't tested it yet.
Comment #7
xpete commentedI've updated the feedapi.module and made some tests.
The only change that i've found is that if i fill a feed url and then submit the project, the project is saved, but if i fill the feed URL, preview the project and then try to submit the feed URL goes empty a i receive the error:
"Feed URL field is required."
And i've got some new error while trying to refresh the feed.
"warning: Invalid argument supplied for foreach() in /srv/www/htdocs/drupal-5.2/modules/feedapi/feedapi.module on line 262.
This feed (http://sourceforge.net/export/rss2_projnews.php?group_id=90363&rss_fullt...) doesn't have any processor. It's not possible to refresh the feed."
I think Souvent22 should be right.
Comment #8
aron novakxpete, here you mentioned another idea. But this is really a support request, it's not related to the bug report. I mean the required URL field.
I'm confident that this is really a required field. Can you imagine a feed without a feed URL? I think it's impossible. You only want to attach feeds to project. It should be a nicer way, i don't think that enabling feedapi for project content-type is the optimal.
About the processor-bug: yes, Souvent22 figured out the problem, thanks!
Comment #9
xpete commented"It should be a nicer way, i don't think that enabling feedapi for project content-type is the optimal."
I have tried all drupal modules related to syndication and the only one that does what i want is FeedAPI.
I think this is the optimal way for me and having one more option doesn't hurt the other module users.
Comment #10
aron novakI have a workaround idea for you: (not nice, but should work)
create a dummy skeleton RSS feed without items and supply that URL at the URL field. (I said in advance that it's not nice :) )
About the bug:
It'll be fixed at the CVS soon, currently there are huge feature improvements.
Comment #11
xpete commented"I have a workaround idea for you: (not nice, but should work)
create a dummy skeleton RSS feed without items and supply that URL at the URL field. (I said in advance that it's not nice :) )"
LOL
I think i will just change this: "'#required' => TRUE," to FALSE. And maybe the the change in the code that i want.
I hope i will not forget to change this when i update the code.
About the bug:
I'm waiting for the patch or the changes in the CVS.
Comment #12
aron novakYour wishes were heard :)
Please check out the CVS and let me know if you're satisfied or not. (in the case of feature and the bug too)
Thanks for the response in advance. If you say that the bug has disappeared, i'll mark this ticket to closed.
Comment #13
xpete commentedthe bug is not fixed.
I will do more tests later.
Comment #14
xpete commentedI've done some test an in the testing enviroment i've created only with Drupal, FeedAPI and Project it works.
In the complete instalation of my website it didn't work gives me this message when i try to refresh the feed:
"This feed () doesn't have any processor. It's not possible to refresh the feed."
And there's nothing in the Feed URL field.
About the feature I've got some strange result that I will test better later.
Comment #15
xpete commentedAbout the feature see this:
http://drupal.org/node/175379
Comment #16
aron novakPlease tell me if the bug has not solved yet at your site!
If not, here is the way to go:
1) Disable all the FeedAPI modules
2) Uninstall FeedAPI within Drupal
3) Delete all the FeedAPI related content-types
4) Delete all the tables (if any) related to FeedAPI
5) Delete FeedAPI module directory
6) grab the module at the module directory:
cvs -z6 -d:pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal-contrib checkout -r DRUPAL-5 -d feedapi contributions/modules/feedapi7) Read the README.txt at feedapi directory (the screencast is outdated, please do not follow that)
7) Enable all the modules of FeedAPI
8) Try out the feed creation and refresh with one of the FeedAPI created content-type. You don't have to create a content-type. FeedAPI does this job for you (with preconfigured preset) when installing the module.
Comment #17
xpete commentedI've done what you said but i had can't remove the content type project because its created by the project module and even if i could do that i wont do that.
It's still not working. what things feed api changes in the content type?
Comment #18
aron novakCan you take a screenshot of the content-type editing page (where the FeedAPI is enabled and you'd like to use for aggregation)? Or if it's easier to you please send me the dump of your variable SQL table.
What is the error message anyway? Is it the original: "This feed () doesn't have any processor. It's not possible to refresh the feed." ?
Comment #19
aron novakDo you have this bug yet? It'd be good to close or fix this bug, but without more information I cannot make progress on it. Thanks in advance.
Comment #20
xpete commentedSorry for the late reply.
The error is the same and the feedapi table in the db are still empty.
i will see the variables ASAP.
Comment #21
aron novakCan you give me access to that site? It could be the easiest way for me to see the big picture.
Comment #22
cacciaresi commentedHello, I am having the same problem, but when i'm importing from an OPML list, all the information of the feed are loaded fine, but the URL of the feed is not set.
I debug a little, but i can not understand exactly what is going on, because the XML file (opml) is loaded correctly. i mean the XMLURL attribute of the file is correctly loaded.
This is the XML
I have the 4th october dev version of the module.
I also test this xml with the demo web site, and in that case the XML is correctly loaded.
Any suggestion? What can i try? I DO NOT have clean url on, can that be the problem?
I hope you can help me, i really need to import OPML files to my site.
Thanks a lot, Claudio.
Comment #23
xpete commentedI've put my hands in your code and done the attached patch.
With this now my feed link goes in to the db but i still have a problem when refreshing
"This feed (http://localhost/mosel/?q=rss.xml) doesn't have any processor. It's not possible to refresh the feed."
Comment #24
cacciaresi commentedI would like to add, that in my case, when the opml file is imported, no data is inserted in the database. Please any help will be appreciate.
Comment #25
aron novakxpete: is your site localized? If yes, please get the latest code from the CVS and the things will work. Johannes Wilm was so kind and allowed me to dig into the problem at his environment.
Comment #26
aron novakcacciaresi: I found the bug at OPML importing process, please get the latest source code from the CVS (here's how: http://aggregation.novaak.net/?q=node/321) and try it out. At my site i could reproduce the bug that you mentioned and now it's fixed. Thanks for reporting it.
Comment #27
cacciaresi commentedExcellent, i update the code with the difference in your commit, and it works perfect, as you can see, my PHP knowledge is ZERO!!!! :)
It worked perfect!
Thanks a lot, the module is working perfect for me.
Another question, do you in mind a maximum number of feeds that can be imported in an OPML file?
Comment #28
aron novakcacciaresi:
I'm glad that your problem is fixed :)
Yeah, the module won't handle huge OPML files with thousand feeds, because of PHP-timeout. I see the following solution:
If a huge OPML file comes in, the module should store it and process it at cron-time (imagine: 1st cron run: create 50 feeds, 2nd cron run: 50 ... Xth cron run: finish the given huge OPML)
So the OPML perfect is not fool-proof at the moment.
Comment #29
cacciaresi commentedYes, exactly, i have test the module with a 23,6 KB (24.193 bytes) file, and it hangs up...
I think that what you say is a good idea.
The timeout can be specified?
Thanks again!
Comment #30
cacciaresi commentedHello again :)
I think that i have another problem, when the nodes arew created using the import OPML option, the default options os the node are not valid. I mean, Autor information, promote to fron page, etc..
When I add a node using Content->add option menu, everything works perfect, but when the feeds are loaded using the import, none of these setting is being taking in account.
Please, any help will be help. :)
bye,
claudio.
Comment #31
cacciaresi commentedHello again :) :)
I think that I found a workaround to this problem...
here is the code that i am using right now:
I added the user, and it is working, i also add the status = 1 to set to publish to the node, and to promote to front page.
I think that this fix my problem.
by and thanks a again for everything from Argentina.
Comment #32
xpete commentedcacciaresi: please don't steal my issues. Open your own issue reports if not related with this one. :-P
Aron Novak: my site is localized that change didn't fixed my problem, please see my patch.
The feedapi module only update already existing feeds but i what to put new feed in already existing nodes, that why my feed didn't go in to DB, my patch fixes that but i don't know if creates more problems.
Comment #33
aron novakxpete: sorry, but your patch is not okay at all. It will definitely brake the other parts. The problem is that likely the case 'submit': of feedapi_nodeapi is not called.
Please share me more details as I asked you before to help you! You have not replied at all to my #21, and #18 comments. Without details I cannot help.
Comment #34
xpete commentedI thought that you could figure out what the problem is looking for the patch and my comment.
I will try to explain better.
In the nodeapi you have this:
db_query("UPDATE {feedapi} SET items_delete = %d WHERE nid = %d",
$node->feedapi['feedapi_items_delete'],
$node->nid
);
this code only update update feed in nodes that are created as feed from the begin, I'm trying to use already existing node that never had a feed url and so the WHERE nid = %d" will return nothing and nothing will be inserted in the DB table. I you use a delete folowed by a insert you will never have problems. My patch was not to be commited but to help you figure it out.
Sorry for my english.
Comment #35
aron novakFinally I understood your problem. I can reproduce it. This is really a bug. You can expect the fix today or tomorrow.
Comment #36
aron novakI committed the fix. Please check if i really found your problem or not. Thanks for your tough help!
Comment #37
xpete commentedYou didn't understand the problem.
You patch still try to update something that isn't there.
Comment #38
xpete commentedDo something like that:
create a new story(or any kind of content), save it and edit it again to insert a feed url in the story.
After that go to db and see that's nothing there.
You have updated the node but didn't update the table because there's already nothing to update in the DB.
You should NOT use the UPDATE query.
Comment #39
aron novakThis bug is really fixed now.
The problem was:
if the node is created before the content-type is enabled for feedapi, feedapi behaved strangely.
Comment #40
xpete commentedComment #41
xpete commentedregression
Other error message, same problem.
Comment #42
aron novakxpete: I'm so sorry! The lines, that did the fix, were removed accidentally because of huge refactoring. I restored the original situation when it was fixed (because of the refactoring i had to modified those lines a little bit)
Please let me know if it's not fixed now.
Comment #43
xpete commented