When configuring an instance of a Relation Select field on the manage fields form on an entity type the "Relation type" select box is only population relations that exist in the database. (It's populating this form element via relation_select_get_relation_types() )

Relation types that live in code by using features or perhaps a custom module that defines the relation type are not allowed to be used at all.

Relation types that exist in code need to be considered in relation_select_get_relation_types().

CommentFileSizeAuthor
#3 relation_select-types-in-code-1721824-3.patch1.63 KBvordude
#1 relation_select-types-in-code-1721824-1.patch1.48 KBvordude

Comments

vordude’s picture

vordude commented
Assigned: Unassigned » vordude
Status: Active » Needs review
StatusFileSize
new relation_select-types-in-code-1721824-1.patch1.48 KB

Welp, something like this ought to do it.

Essentially we're taking the list of relations that the system knows about by using the relation_get_types() api function from the relation module instead of querying the database directly.

Then sort through all of the relations to see which ones would apply to this entity bundle.

It would be super sweet if there was a way to do this without sorting through every relation type, but I'm not sure you can.

Querying the database is certainly more efficient memory-wise but doesn't pick up relation types that are in code.

steveoliver’s picture

steveoliver commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. Works as described. Anyone see anything wrong with it? I think we need to start implementing tests and maybe even requiring tests for patches/new commits.

vordude’s picture

vordude commented
StatusFileSize
new relation_select-types-in-code-1721824-3.patch1.63 KB

Yes. I do. This is way better...sorry.

I say use the Relation API as much as possible.

vordude’s picture

vordude commented
Status: Reviewed & tested by the community » Needs review
steveoliver’s picture

steveoliver commented
Status: Needs review » Reviewed & tested by the community

Oh, yeah, that's more like it!

steveoliver’s picture

steveoliver commented

We get all relation types available for an entity type by calling the Relation API, not from a direct db_select(), so that relation types that are not in the database (i.e. in code) can be options when configuring a relation select field.

Committed to 7.x-1.x in f5368a5. Changing title.

Thanks, vordude.

Jorrit’s picture

Jorrit commented
Title: Relation types not in the database are not an option when configuring the field » Get relation types from Relation API
Status: Reviewed & tested by the community » Closed (fixed)

The function relation_select_add_relation_form() still refers to relation_select_get_relation_types(). I guess this is a matter of a simple replace?

steveoliver’s picture

steveoliver commented

You were right, Jorrit. Thanks. The last two remaining instances of relation_select_get_relation_types have been replaced in b59b042.