| Project: | Bibliography Module |
| Version: | 7.x-1.0-rc4 |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | active |
Issue Summary
Description
A fresh install of Biblio, with all sub-modules enabled, produced warnings and then strict warning after the first reference was entered.
By a process of elimination, Citeproc seems to be the cause. I have disenabled just that sub-module and the rest of the modeule appears to work fine.
More information
The specifications of my installation are
Drupal 7.15
PHP 5.4.5
Uniform Server (Apache and MySQL) on Windows 7
Bibliography Module 7.x-1.0-rc4
Also installed: pathauto, token, wysiwyg, ckeditor (library), ctools, views, panels, media, date api, calendar, footnote, book (core)
Biblio styles are enabled in both Filter and full HTML (below Footnote as recommended.
Feedback from Drupal
This notice came up on clicking Biblio in default Navigation menu when all sub-modules were enabled (no other changes to default install).
Notice: Array to string conversion in biblio_page_content() (line 218 of C:\ScholarWriter\www\drupal\sites\all\modules\biblio\includes\biblio.pages.inc).
The warnings appeared on selecting author in default Navigation menu (before doing to the preferences or adding a reference). [Attached]
These warnings follow Add Content and saving (without changing any preferences).
• Strict warning: Declaration of csl_names::render() should be compatible with csl_collection::render($data, $mode = NULL) in module_load_include() (line 329 of C:\ScholarWriter\www\drupal\includes\module.inc).
• Strict warning: Declaration of csl_date::render() should be compatible with csl_collection::render($data, $mode = NULL) in module_load_include() (line 329 of C:\ScholarWriter\www\drupal\includes\module.inc).
• Strict warning: Declaration of csl_date_part::render() should be compatible with csl_collection::render($data, $mode = NULL) in module_load_include() (line 329 of C:\ScholarWriter\www\drupal\includes\module.inc).
• Strict warning: Declaration of csl_number::render() should be compatible with csl_collection::render($data, $mode = NULL) in module_load_include() (line 329 of C:\ScholarWriter\www\drupal\includes\module.inc).
• Strict warning: Declaration of csl_group::render() should be compatible with csl_collection::render($data, $mode = NULL) in module_load_include() (line 329 of C:\ScholarWriter\www\drupal\includes\module.inc).
• Strict warning: Declaration of csl_layout::render() should be compatible with csl_collection::render($data, $mode = NULL) in module_load_include() (line 329 of C:\ScholarWriter\www\drupal\includes\module.inc).
Temporary solution: Disenable Cite Proc and warnings have gone.
Comments
#1
Can't see why I can't add the screenclip in an edit. Here it is.
#2
These are actually two different issues (only the latter involves CiteProc).
I've fixed the first issue "Notice: Array to string conversion in biblio_page_content() (line 218..." (http://drupalcode.org/project/biblio.git/commit/a2be586v).
The second "CiteProc" issue has already been fixed (in 7.x-1.x-dev)
#3
Hello rjerome:
I activated CiteProc and then displayed a reference that was working previously. This is a clean build of Drupal 7.
Immediately I got the messages below. When I deactivated Citeproc, the messages cleared.
Strict warning: Declaration of csl_names::render() should be compatible with csl_collection::render($data, $mode = NULL) in module_load_include() (line 329 of C:\ScholarWriter\www\drupal\includes\module.inc).
Strict warning: Declaration of csl_date::render() should be compatible with csl_collection::render($data, $mode = NULL) in module_load_include() (line 329 of C:\ScholarWriter\www\drupal\includes\module.inc).
Strict warning: Declaration of csl_date_part::render() should be compatible with csl_collection::render($data, $mode = NULL) in module_load_include() (line 329 of C:\ScholarWriter\www\drupal\includes\module.inc).
Strict warning: Declaration of csl_number::render() should be compatible with csl_collection::render($data, $mode = NULL) in module_load_include() (line 329 of C:\ScholarWriter\www\drupal\includes\module.inc).
Strict warning: Declaration of csl_group::render() should be compatible with csl_collection::render($data, $mode = NULL) in module_load_include() (line 329 of C:\ScholarWriter\www\drupal\includes\module.inc).
Strict warning: Declaration of csl_layout::render() should be compatible with csl_collection::render($data, $mode = NULL) in module_load_include() (line 329 of C:\ScholarWriter\www\drupal\includes\module.inc).
OTHER ISSUES
1. Whenever I use Biblio Citation in a view, it breaks. Sorry don't have the error message to hand.
2. When using American Psych Association style, the book citation does not render. The publisher and city get lost. The data is there because when I switch to Chicago, the full reference renders properly.
#4
Those strict warnings have definitely been fixed in the -dev version, so it looks like you might still be using the -rc4 version?
Could you confirm the version you have, and try the -dev version if you don't already have it.
#5
The -rc4 version. Is it OK to use a dev version? Seems counter intuitive.
#6
I've been meaning to roll out a new release, but there always seems to be just one more thing I want to do before doing it.
The bottom line is, yes it's OK to use the -dev release. It is the bleeding edge (has all the latest fixes and features) and I rarely commit anything that doesn't work to that branch. When a new release comes along, you can just switch to it at that time.
#7
I have installed the latest dev version and activated citeproc and I am able to print out citations.
Now my Configuration page is flooded with this message. And I mean flooded. This message fundamentally breaks the Drupal site for the average academic user who will be panicked and distracted by having to scroll down a page or two to change their username or whatever.
Notice: Array to string conversion in biblio_token_info() (line 8 of C:\ScholarWriter\www\drupal\sites\all\modules\biblio\biblio.tokens.inc).
Also the Chicago author style broke in Views.
I've tried disconnecting citeproc (and clearing caches) to try to test what prompted the message. But have not succeeded.
Any ideas.
Btw, with respect to use-cases - stability is important for us to be able to use Biblio with academics. Limitations are less important than utter predictability at the user end. So releases are very important too, otherwise we have to run our repo to track which version of dev we are using.
For now, I am contemplating living with the broken citeproc and broken APA because the string of messages would be worse.
Suggestions?
#8
I will look into those warnings (obviously there shouldn't be any), but in the mean time, you could simply turn off the display of warnings and then your users won't be troubled by them.
#9
Hi rjerome
my drupal is 7.1.8 and biblio module is 7x.1.0cr4
i got this error.
Github_HttpClient_Exception: HTTP 404: Not Found in Github_HttpClient_Curl->doRequest()
(line 72 of .../sites/all/modules/biblio/modules/CiteProc/Github/HttpClient/Curl.php)
please help me. I need urgent.
I also can't add Harvard style 3 which i downloaded from
http://www.zotero.org/styles/harvard3 and uploaded into
biblio\modules\CiteProc\style\
but not working..
Please help
#10
I would suggest upgrading to the 7.x-1.x-dev version. That issue has been fixed in that version. I've been meaning to push a new release, but there is always just "one more thing" to add...