When used with Exclude node title module http://drupal.org/project/exclude_node_title/, [node:title] is empty, which I guess is kind of expected really.
It would be useful if that wasn't the case though.

CommentFileSizeAuthor
#12 metatag-n1722564-12.patch1.77 KBdamienmckenna
#11 metatag-n1722564-11.patch1.79 KBdamienmckenna
#6 metatag-n1722564-6.patch641 bytesdamienmckenna

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review

Per antonyanimator in #1721026: Undefined index errors and Page Title not displaying in the browser, try using [current-page:title] as the value for the tag.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Exclude node title module » Compatibility problem with Exclude Node Title module
Status: Needs review » Active

Clarifying the title.

hixster’s picture

hixster commented

sorry I never came back on this [current-page:title] worked. thanks

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Component: Code » Documentation
Category: bug » task

Thanks for the update, lets leave this open as a documentation task.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Marked #1864284: Incompatible with metatag module as a duplicate.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new metatag-n1722564-6.patch641 bytes

Is something like this sufficient?

Status: Needs review » Needs work

The last submitted patch, metatag-n1722564-6.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-1.0-alpha7 » 7.x-1.x-dev
Status: Needs work » Needs review
damienmckenna’s picture

damienmckenna
Location TN, USA
commented

#6: metatag-n1722564-6.patch queued for re-testing.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

IMO it would be better to have a hook_enable or hook_requirements that detects the installation of both modules and complains about it.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n1722564-11.patch1.79 KB

@greggles: We happen to have something similar to that for the Page Title module already. How does the included message work - too verbose?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n1722564-12.patch1.77 KB

Improved/fixed the hook_requirements message.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed, thanks for the help everyone.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.