Notice: Undefined index: file in media_edit_submit() [#1723820]

Posted by rychu90 on August 11, 2012 at 11:20am

6 followers

Issue Summary

I added field "description" to image file type. Everything went ok but when i tried to fill this field under admin/content/media and saved it i see this message:
Notice: Undefined index: file in media_edit_submit() (line 366 of (...)\drupal\sites\all\modules\media\includes\media.pages.inc).
EntityMalformedException: Missing bundle property on entity of type file. in entity_extract_ids() (line 7562 of (...)\drupal\includes\common.inc).

Comments

#1

Posted by rychu90 on August 13, 2012 at 6:35pm

Priority:

normal

» major

#2

Posted by tedbow on August 23, 2012 at 4:10pm

Version:	7.x-1.2	» 7.x-1.x-dev
Category:	support request	» bug report
Status:	active	» needs review

I have attached a patch that fixes this issue for me.

I believe this is caused $form_state is not passed by reference to the function media_edit. So right now:

function media_edit($form, &$form_state, $file) {
  $form_state['file'] = $file;

Doesn't affect $form_state outside of the form. Then in

function media_edit_submit($form, &$form_state) {
  $file = $form_state['file'];

The file is not actually in $form_state.

Attachment	Size	Status	Test result	Operations
media-pass_form_state_byref_media_edit-1723820-2.patch	489 bytes	Idle	FAILED: [[SimpleTest]]: [MySQL] 11 pass(es), 0 fail(s), and 12 exception(s).	View details