The <hN> tags come with the following header styles in themes/garland/style.css:
h1 {
font-size: 170%;
}
h2 {
font-size: 160%;
line-height: 130%;
}
h3 {
font-size: 140%;
}
h4 {
font-size: 130%;
}
h5 {
font-size: 120%;
}
h6 {
font-size: 110%;
}
<h2> is used for the node title, only <h3>, <h4>, and <h5> are actually usable in body text, but (at least on Windows) the differences among them and to the <p> style are too small to be useful.
I'd suggest changing <h3> and <h4> as follows:
h3 {
font-size: 140%;
font-weight: bold;
}
h4 {
font-size: 120%;
font-weight: bold;
}
The attached screenshot shows the rendering by the current style.css, and the bottom three lines are my proposal (leaving <h5> as it is).
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | style-172383-1.patch | 35.9 KB | yasir farooqui |
| #8 | Garland-font-samples.Safari 1.3.2_Mac OS X 10.3.png | 45.61 KB | salvis |
| #7 | Garland-font-samples.Safari 3.0.2_Windows 2000.png | 47.35 KB | salvis |
| #6 | Garland-font-samples.Opera 9.23_Ubuntu 6.06.png | 22.32 KB | salvis |
| #5 | Garland-font-samples.MSIE 7.0_Windows XP.png | 23.78 KB | salvis |
Comments
Comment #1
jrabeemer commentedHow does that look in other browsers and on Mac?
Comment #2
salvisHere's a test page.
In IE6 the current styles are slightly more distinct than in FF2(Win), but increasing the differences would still be a benefit IMO.
I don't have any other browsers to test with. If you have one, please post a screenshot of the test page (just the font samples). Thanks!
Comment #3
jrabeemer commentedGo here and test it yourself. http://browsershots.org/
Comment #4
salvisOk, thanks for the hint. I let BrowserShots create all eleven screenshots and here are the results.
Firefox 1.5 and 2.0 look very similar, even between Ubuntu and Win2K.
In the current styles, <h3> is a bit wider than <h4>, but it's the same height, which may even make it look shorter. The more distinctive <h3> and <h4> styles are better IMO.
All browsers show <h5> about the same size as body text, in italic style, and this is fine. I won't comment on this any further.
P.S. Since I can only upload one picture at a time, I'll keep adding a few follow ups here...
Comment #5
salvisIE6 (see #2 above) is the most distinctive. It seems like the Garland's font selection was optimized for IE6.
IE55 is quite similar as far as font rendering is concerned, but if fails to properly render the page (no sidebar, no Garland background).
IE7 (screenshot attached here) is more in line with the other browsers and would thus benefit as much as they would.
Even MS is moving towards the standard — why should Garland remain focused on an odd implementation?
Comment #6
salvisOf the two other Linux browsers offered by BrowserShots, Konqueror looks very similar to Firefox, but Opera is pathetic: <h3> and <h4> are the same font, and only slightly larger than body text. The proposed change can't separate <h3> and <h4>, but at least you can distinguish them from normal text...
Comment #7
salvisSafari on Windows uses much heavier typefaces, but otherwise it's in line with the crowd and would benefit from a more distinctive <h3> style.
Comment #8
salvisSafari on the Mac is not as heavy as on Windows, but it has another wierd property: its body text is much smaller than with all other browsers, it's even smaller than <h6>!
Still, <h3> and <h4> are quite similar as with all the other conforming browsers, and Safari on the Mac would benefit from the proposed change just like all the others.
P.S. This is the last of the screenshots from BrowserShots. If you have other browsers or want to verify the results, please check the test page directly and post your screenshots.
Comment #9
yasir farooqui commentedHi,
Here is my patch file.
Comment #10
salvisIssues are not fixed until a patch is committed.
When you post a patch, you set the Status to "patch (code needs review)".
Something is wrong with your patch. Rather than showing whatever changes you've made, it replaces the complete file. This is probably the result of your editor changing the newline characters of each and every line. Try using a different editor — the patch file should only show the lines that you've effectively changed.
Comment #11
dpearcefl commentedConsidering the time elapsed between now and the last comment plus the fact that D5 is no longer supported, I am closing this ticket.