CommentFileSizeAuthor
#89 views-1724452-89.patch656.5 KBdawehner
#85 views-1724452-85.patch655.49 KBdawehner
#82 views-1724452-82.patch655.49 KBdawehner
#80 views-1724452-80.patch655.9 KBdawehner
#78 views-1724452-78.patch656.57 KBtim.plunkett
#72 views-1724452-72.patch657.54 KBdawehner
#69 views-1724452-69.patch656.81 KBdawehner
#67 views-1724452-67.patch656.81 KBdawehner
#65 views-1724452-65.patch656.22 KBdawehner
#62 views-1724452-61.patch654.65 KBdawehner
#57 views-1724452-57.patch655.08 KBtim.plunkett
#55 views-1724452-55.patch654.37 KBtim.plunkett
#53 views-1724452-53.patch654.75 KBtim.plunkett
#51 views-1724452-51.patch655.53 KBtim.plunkett
#48 views-1724452-48.patch652 KBtim.plunkett
#45 views-1724452-45.patch651.69 KBtim.plunkett
#43 views-1724452-43.patch651.47 KBtim.plunkett
#41 views-1724452-41.patch648.76 KBtim.plunkett
#39 views-1724452-39.patch648.6 KBtim.plunkett
#37 views-1724452-37.patch639.63 KBtim.plunkett
#35 views-1724452-35.patch636.17 KBtim.plunkett
#32 views-1724452-32.patch633.73 KBtim.plunkett
#29 views-1724452-29.patch633.92 KBdawehner
#27 views-1724452-27.patch633.73 KBdawehner
#25 views-1724452-25.patch632.2 KBdawehner
#23 views-1724452-23.patch643.58 KBtim.plunkett
#21 views-1724452-20.patch631.63 KBdawehner
#19 views-1724452-18.patch631.34 KBdawehner
#18 views-1724452-18.patch643.26 KBtim.plunkett
#15 views-1724452-15.patch632.85 KBtim.plunkett
#13 views-1724452-13.patch612.25 KBtim.plunkett
#13 interdiff.txt1.66 KBtim.plunkett
#11 views-1724452-11.patch610.89 KBtim.plunkett
#9 views-1724452-9.patch611.36 KBtim.plunkett
#7 views-1724452-7.patch614.27 KBtim.plunkett
#3 views-1724452-3.patch627.71 KBtim.plunkett
#1 views-1724452-1.patch618.34 KBtim.plunkett

Comments

tim.plunkett’s picture

Status: Active » Needs review
StatusFileSize
new618.34 KB
tim.plunkett’s picture

StatusFileSize
new627.71 KB
tim.plunkett’s picture

Status: Needs review » Needs work

I can't remember the reason, but we decided to move the non-Views plugins (node, user, etc.) to our own Views vendor.

It works fine with the Simpletest GUI, but not at all from run-tests.sh :(

aspilicious’s picture

In fact that is a hack :). So it's actually good that annotation branch fails. Although it sucks because we can't merge in before :p

tim.plunkett’s picture

Status: Needs work » Needs review
StatusFileSize
new614.27 KB

This might only fix a couple of the tests, but if it helps any we know what to do :)

(Calling views_init() from setUp())

tim.plunkett’s picture

StatusFileSize
new611.36 KB

My commit to fix 8.x-3.x broke this patch.

Status: Needs review » Needs work

The last submitted patch, views-1724452-9.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
StatusFileSize
new610.89 KB

Trying without the DIC changes.

Status: Needs review » Needs work

The last submitted patch, views-1724452-11.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
StatusFileSize
new1.66 KB
new612.25 KB

Okay, here's a stop gap fix for the Wizard.

Status: Needs review » Needs work

The last submitted patch, views-1724452-13.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
StatusFileSize
new632.85 KB

Pulled in aspilicious's handler fixes.

Status: Needs review » Needs work

The last submitted patch, views-1724452-15.patch, failed testing.

dawehner’s picture

Just fixed the math testcase.

tim.plunkett’s picture

Status: Needs work » Needs review
StatusFileSize
new643.26 KB

Let's try another one.

dawehner’s picture

StatusFileSize
new631.34 KB

Let's hope this fixes at least some of the wizard tests.

dawehner’s picture

StatusFileSize
new631.63 KB

Just another small fix

tim.plunkett’s picture

StatusFileSize
new643.58 KB

Combined those with mine.

dawehner’s picture

StatusFileSize
new632.2 KB

Just a try

dawehner’s picture

StatusFileSize
new633.73 KB

9fd0952
Here is another patch which should fix some of the argument tests, at least in theory, though they didn't worked locally.

dawehner’s picture

StatusFileSize
new633.92 KB

Small steps, i really hate all this pointless commits.

tim.plunkett’s picture

@dawehner you dont have to commit them all, you can use a patch now. :)

tim.plunkett’s picture

StatusFileSize
new633.73 KB

I'm getting max_execution_time errors locally :(

tim.plunkett’s picture

Status: Needs review » Needs work

Okay so #32 just enabled views_test for RelationshipNodeTermDataTest.php...

tim.plunkett’s picture

Status: Needs work » Needs review
StatusFileSize
new636.17 KB

Added a couple more commits by me, @aspilicious and @damiankloip

tim.plunkett’s picture

StatusFileSize
new639.63 KB

Forcing views_ui to be enabled.

tim.plunkett’s picture

StatusFileSize
new648.6 KB

Temporarily rename ViewsTestBase to ViewsSqlTest.

tim.plunkett’s picture

StatusFileSize
new648.76 KB

I think that views_ui and views_test are being enabled too early, removing them from $modules.
This fixed a couple tests for me locally.

tim.plunkett’s picture

StatusFileSize
new651.47 KB

ArgumentDefaultTest depends on node and taxonomy
Switch definition[name] to definition[id]
Switch the remaining 'uses FOO' to 'uses_FOO'

tim.plunkett’s picture

StatusFileSize
new651.69 KB

More mucking around.

tim.plunkett’s picture

Status: Needs review » Needs work

Ignore the patch in #45.

tim.plunkett’s picture

Status: Needs work » Needs review
StatusFileSize
new652 KB

This just sticks menu_router_rebuild() straight into views_invalidate_cache() just to see what will happen.

This will probably triple the length of the test run.

tim.plunkett’s picture

StatusFileSize
new655.53 KB

I guess that was to be expected :(

This one should NOT crash the bot :)

Rebuild the menu after saving a new view.
Add module names to all core plugins.
Allow plugins to specify a module, and check for module_exists().

tim.plunkett’s picture

StatusFileSize
new654.75 KB

The override parameter of views_get_handler was removed, but it was still being used. Added it back in a modified form.

tim.plunkett’s picture

StatusFileSize
new654.37 KB

That didn't haven enough passes. Added some stupid code to _views_create_handler() with an @todo.

tim.plunkett’s picture

StatusFileSize
new655.08 KB

Fixed up the re-added test, and corrected another handler.

webchick’s picture

Status: Needs review » Needs work
aspilicious’s picture

I spend 3 hours on the tagged_with bug. (and thats an actual bug)
I discovered the "ManyToOneHelper" class is pety useless :p

It gets called like this:
new ManyToOneHelper($this);

But the class doesn't have a constructor only this obscure function

  function ManyToOneHelper(&$handler) {
    $this->handler = &$handler;
  }

So I thought, hey lets change this into a constructor but than you get infinite recursion somewhere.

Short story:
$this->handler
Inside the ManyToOneHelper is always NULL

aspilicious’s picture

What ever happens with the next patch, the localization stuff is still broken. Damian added http://drupalcode.org/sandbox/damiankloip/1685040.git/commit/58795406bd2... but the test is a corrupt mess so its hiding the bug now...

dawehner’s picture

Status: Needs work » Needs review
StatusFileSize
new654.65 KB

Uploaded a patch which fixes the many to one handler.

aspilicious’s picture

Status: Needs review » Needs work

Wizard exception fail:

Drupal\Component\Plugin\Exception\PluginException: The plugin (file) did not specify an instance class.
Just to let you now...

dawehner’s picture

Status: Needs work » Needs review
StatusFileSize
new656.22 KB

... another try, not yet committed but this sounds helpful

dawehner’s picture

StatusFileSize
new656.81 KB

Or this one

dawehner’s picture

StatusFileSize
new656.81 KB

Just a random try :(

tim.plunkett’s picture

Status: Needs review » Needs work

its getting close!
please don't merge this in yet, even after it all passes. I want to see I'd I can clean up some merges.

dawehner’s picture

Status: Needs work » Needs review
StatusFileSize
new657.54 KB

Okay wizard jump menu take that!

aspilicious’s picture

Now the US people can fix the last test! Fix the localization stuff!;)

aspilicious’s picture

Status: Needs review » Needs work

actually taxonomy_term_data *is* the correct tablename. I retested this by creating a taxonomy jump menu view and printed the table name.

But than you get this error:
"Failed to set wizard_key ==> taxonomy_term_data"
Wtf?

dawehner’s picture

Well the plugin id is "taxonomy_term", so $base_table is somehow named not optimal in the test. This is so really not the actual problem of the brokenness.

aspilicious’s picture

For some reason the taxonomy passes with the new id here (no idea why...) but its failing on node revisions. ANd thats actually broken.

  'i' => 'id',
  'n' => 'nid',
  '' => true,
  '_1' => 
  array (
    'id' => '_1',
  ),

Is part of $this->display_handler->get_option('fields')

Looks like a broken join or something like that...

tim.plunkett’s picture

Status: Needs work » Needs review
StatusFileSize
new656.57 KB

path_fields_supplemental was a double nested array in D7, I just wrapped it when using it instead of messing with the annotation.

Status: Needs review » Needs work

The last submitted patch, views-1724452-78.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review
StatusFileSize
new655.9 KB

Reverted your "temporary fix" and added a working one. We are getting close!

Status: Needs review » Needs work

The last submitted patch, views-1724452-80.patch, failed testing.

dawehner’s picture

StatusFileSize
new655.49 KB

My fault...

dawehner’s picture

Status: Needs work » Needs review

switching back to odd numbers, i'm sorry.

Status: Needs review » Needs work

The last submitted patch, views-1724452-82.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review
StatusFileSize
new655.49 KB

...

Status: Needs review » Needs work
Issue tags: -VDC

The last submitted patch, views-1724452-85.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review

#85: views-1724452-85.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +VDC

The last submitted patch, views-1724452-85.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review
StatusFileSize
new656.5 KB

The translation test it so much broken, so i commented it out and added a fixme.

Now it's time to get the merge in and cleanup the tests together.

tim.plunkett’s picture

Status: Needs review » Fixed

I committed this as a patch and gave myself credit...
Just kidding!

MERGED! Now we definitely have something to celebrate in Munich!

webchick’s picture

OH. MY. GOD.

You all ROCK SO HARD!!!!! seriously, SERIOUSLY well done!!!

Automatically closed -- issue fixed for 2 weeks with no activity.