Closed (fixed)
Project:
Views (for Drupal 7)
Version:
8.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
12 Aug 2012 at 01:57 UTC
Updated:
4 Jan 2014 at 02:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
tim.plunkettComment #3
tim.plunkettCommitted #1711640: Module enabling in tests is changed (for drupal 8) to the sandbox.
Comment #5
tim.plunkettI can't remember the reason, but we decided to move the non-Views plugins (node, user, etc.) to our own Views vendor.
It works fine with the Simpletest GUI, but not at all from run-tests.sh :(
Comment #6
aspilicious commentedIn fact that is a hack :). So it's actually good that annotation branch fails. Although it sucks because we can't merge in before :p
Comment #7
tim.plunkettThis might only fix a couple of the tests, but if it helps any we know what to do :)
(Calling views_init() from setUp())
Comment #9
tim.plunkettMy commit to fix 8.x-3.x broke this patch.
Comment #11
tim.plunkettTrying without the DIC changes.
Comment #13
tim.plunkettOkay, here's a stop gap fix for the Wizard.
Comment #15
tim.plunkettPulled in aspilicious's handler fixes.
Comment #17
dawehnerJust fixed the math testcase.
Comment #18
tim.plunkettLet's try another one.
Comment #19
dawehnerLet's hope this fixes at least some of the wizard tests.
Comment #21
dawehnerJust another small fix
Comment #23
tim.plunkettCombined those with mine.
Comment #25
dawehnerJust a try
Comment #27
dawehner9fd0952
Here is another patch which should fix some of the argument tests, at least in theory, though they didn't worked locally.
Comment #29
dawehnerSmall steps, i really hate all this pointless commits.
Comment #30
tim.plunkett@dawehner you dont have to commit them all, you can use a patch now. :)
Comment #32
tim.plunkettI'm getting max_execution_time errors locally :(
Comment #34
tim.plunkettOkay so #32 just enabled views_test for RelationshipNodeTermDataTest.php...
Comment #35
tim.plunkettAdded a couple more commits by me, @aspilicious and @damiankloip
Comment #37
tim.plunkettForcing views_ui to be enabled.
Comment #39
tim.plunkettTemporarily rename ViewsTestBase to ViewsSqlTest.
Comment #41
tim.plunkettI think that views_ui and views_test are being enabled too early, removing them from $modules.
This fixed a couple tests for me locally.
Comment #43
tim.plunkettArgumentDefaultTest depends on node and taxonomy
Switch definition[name] to definition[id]
Switch the remaining 'uses FOO' to 'uses_FOO'
Comment #45
tim.plunkettMore mucking around.
Comment #47
tim.plunkettIgnore the patch in #45.
Comment #48
tim.plunkettThis just sticks menu_router_rebuild() straight into views_invalidate_cache() just to see what will happen.
This will probably triple the length of the test run.
Comment #51
tim.plunkettI guess that was to be expected :(
This one should NOT crash the bot :)
Rebuild the menu after saving a new view.
Add module names to all core plugins.
Allow plugins to specify a module, and check for module_exists().
Comment #53
tim.plunkettThe override parameter of views_get_handler was removed, but it was still being used. Added it back in a modified form.
Comment #55
tim.plunkettThat didn't haven enough passes. Added some stupid code to _views_create_handler() with an @todo.
Comment #57
tim.plunkettFixed up the re-added test, and corrected another handler.
Comment #59
webchickComment #60
aspilicious commentedI spend 3 hours on the tagged_with bug. (and thats an actual bug)
I discovered the "ManyToOneHelper" class is pety useless :p
It gets called like this:
new ManyToOneHelper($this);But the class doesn't have a constructor only this obscure function
So I thought, hey lets change this into a constructor but than you get infinite recursion somewhere.
Short story:
$this->handlerInside the ManyToOneHelper is always NULL
Comment #61
aspilicious commentedWhat ever happens with the next patch, the localization stuff is still broken. Damian added http://drupalcode.org/sandbox/damiankloip/1685040.git/commit/58795406bd2... but the test is a corrupt mess so its hiding the bug now...
Comment #62
dawehnerUploaded a patch which fixes the many to one handler.
Comment #64
aspilicious commentedWizard exception fail:
Drupal\Component\Plugin\Exception\PluginException: The plugin (file) did not specify an instance class.
Just to let you now...
Comment #65
dawehner... another try, not yet committed but this sounds helpful
Comment #67
dawehnerOr this one
Comment #69
dawehnerJust a random try :(
Comment #71
tim.plunkettits getting close!
please don't merge this in yet, even after it all passes. I want to see I'd I can clean up some merges.
Comment #72
dawehnerOkay wizard jump menu take that!
Comment #73
aspilicious commentedNow the US people can fix the last test! Fix the localization stuff!;)
Comment #75
aspilicious commentedactually taxonomy_term_data *is* the correct tablename. I retested this by creating a taxonomy jump menu view and printed the table name.
But than you get this error:
"Failed to set wizard_key ==> taxonomy_term_data"
Wtf?
Comment #76
dawehnerWell the plugin id is "taxonomy_term", so $base_table is somehow named not optimal in the test. This is so really not the actual problem of the brokenness.
Comment #77
aspilicious commentedFor some reason the taxonomy passes with the new id here (no idea why...) but its failing on node revisions. ANd thats actually broken.
Is part of
$this->display_handler->get_option('fields')Looks like a broken join or something like that...
Comment #78
tim.plunkettpath_fields_supplemental was a double nested array in D7, I just wrapped it when using it instead of messing with the annotation.
Comment #80
dawehnerReverted your "temporary fix" and added a working one. We are getting close!
Comment #82
dawehnerMy fault...
Comment #83
dawehnerswitching back to odd numbers, i'm sorry.
Comment #85
dawehner...
Comment #87
dawehner#85: views-1724452-85.patch queued for re-testing.
Comment #89
dawehnerThe translation test it so much broken, so i commented it out and added a fixme.
Now it's time to get the merge in and cleanup the tests together.
Comment #90
tim.plunkettI committed this as a patch and gave myself credit...
Just kidding!
MERGED! Now we definitely have something to celebrate in Munich!
Comment #91
webchickOH. MY. GOD.
You all ROCK SO HARD!!!!! seriously, SERIOUSLY well done!!!