Gracefully fail if update_status 5.x-1.* is being used

z.stolar - September 2, 2007 - 08:17
Project:CVS deploy
Version:5.x-1.x-dev
Component:Code
Category:task
Priority:normal
Assigned:dww
Status:closed
Description

I'm using CVS to update my site. I've installed update_status and cvs_deploy.
When activating cvs_deploy, I get an error of calling an undefined function update_status_get_project.
This error appears in line 100 of cvs.deploy:

<?php
if (module_exists('update_status')) {
 
$project['project'] = update_status_get_project($file);
}
?>

AttachmentSize
update_status_get_project.patch382 bytes

#1

dww - September 3, 2007 - 20:12
Title:Call to undefined function update_status_get_project» Gracefully fail if update_status 5.x-1.* is being used
Category:bug report» task
Priority:critical» normal
Status:needs review» needs work

CVS deploy is meant for update_status 5.x-2.*. update_status 5.x-1.* is now deprecated, and should no longer be used.

That said, it'd be nice to more gracefully handle this error case. However, the patch here is wrong, and will break things in update_status 5.x-2.* land.

#2

dww - January 11, 2008 - 06:46
Assigned to:Anonymous» dww
Status:needs work» reviewed & tested by the community

like so.

AttachmentSize
cvs_deploy_update_status_2_graceful.patch 1.22 KB

#3

dww - January 11, 2008 - 06:51
Status:reviewed & tested by the community» fixed

Committed to DRUPAL-5 branch. D6 (HEAD) is a whole different story, so I'm going to call this particular issue fixed.

#4

Anonymous (not verified) - January 25, 2008 - 07:01
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.