This patch allows modules to pass in custom local tasks. Pretty much, it removes hard coding of if ($primary = menu_primary_local_tasks()) { which allows modules like Views to use local tasks as tabs. While we're at it, we might as well make phptemplate_body_class more universal as well
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | menu_local_tasks.patch | 2.1 KB | chx |
| #4 | fix_garland_and_menu_theme_2.patch | 7.2 KB | dmitrig01 |
| #3 | fix_garland_and_menu_theme_1.patch | 7.19 KB | dmitrig01 |
| #1 | fix_garland_and_menu_theme_0.patch | 7 KB | dmitrig01 |
| fix_garland_and_menu_theme.patch | 6.86 KB | dmitrig01 |
Comments
Comment #1
dmitrig01 commentedNew patch. Fixes some notices, and much more testing. Tested in every theme, on pages with no tabs, only primary, and both.
Comment #2
dmitrig01 commentedHere's a better description: The views 2 module will provide fake ajax tabs in the administration interface. We want them to look just like local tasks. At the moment, it's not really possible. However, with this simple change, it's really easy.
Comment #3
dmitrig01 commentedBdragon suggested some stuff in IRC
Comment #4
dmitrig01 commentedmissed something
Comment #5
bdragon commentedTested this with all core themes, looks good.
Comment #6
gábor hojtsyHm.
- why would chameleon only print the primary local tasks?
- why not include the default local task retrievals in the theme function and let it be overridable if you want it to
- why complicate the body class function? The point of having these tpl.php files is to have them simple not to introduce conditionals for such simple things as the body class
- functions like garland_preprocess_page() still have the default tab list data used... how does this interfer with your custom tabs, if they are related at all?
Comment #7
dmitrig01 commenteda) uh, because I haven't implemented it yet :D
b) possibly. Still thinking about this one
c) because we might as well make that accessible to modules
d) it does not. Custom tabs are for tabs appearing in *other places*
Comment #8
chx commentedIncomplete work. But there is no way this is D6 or critical.
Comment #9
birdmanx35 commentedBingo: Still works against HEAD.
Comment #10
Jaza commentedCould still be useful. But still needs work. Bump.
Comment #11
mgiffordSo should this issue just be closed? It's seen no movement since 2010.
Comment #12
bradjones1I'm not against that... also I suspect the menu system has changed a bit in 8.x and this was bumped forward out of process, not because the patch necessarily applies to 8.x. Unassigning as well.