Badbehavior Module for Drupal 5.x attached

This module package still appears to be missing the file badbehavior.install, and the function badbehavior_install() containing necessary code to create DB tables.

Here is relevant code from bad-behavior/core.inc.php:

// Our log table structure
function bb2_table_structure($name)
{
        // It's not paranoia if they really are out to get you.
        $name_escaped = bb2_db_escape($name);
        return "CREATE TABLE IF NOT EXISTS `$name_escaped` (
                `id` INT(11) NOT NULL auto_increment,
                `ip` TEXT NOT NULL,
                `date` DATETIME NOT NULL default '0000-00-00 00:00:00',
                `request_method` TEXT NOT NULL,
                `request_uri` TEXT NOT NULL,
                `server_protocol` TEXT NOT NULL,
                `http_headers` TEXT NOT NULL,
                `user_agent` TEXT NOT NULL,
                `request_entity` TEXT NOT NULL,
                `key` TEXT NOT NULL,
                INDEX (`ip`(15)),
                INDEX (`user_agent`(10)),
                PRIMARY KEY (`id`) );"; // TODO: INDEX might need tuning
}

How difficult would it be to wrap this inside the file badbehavior.install correctly? (I.e. by "correctly" I mean so that it handles MySQL vs. PostgreSQL, unisntallation, etc.)

I've manged to fix this. The bad-behavior scripts (and not the associated Drupal module) did indeed create the necessary database table, but it didn't include the db_prefix in the table name, meaning the module couldn't find it.

I fixed this by replacing all instances of 'bad_behavior_log' with db_prefix_tables('{bad_behavior_log}') in the file badbehavior.module. Note that the single quotes should be *included* in those strings. Also note that I also had to delete the row named "badbehavior_db_installed" from the {variable} table to get the BB2 scripts to reinstall their log table.

This is really another reason why the file badbehavior.install is necessary, since you can define the function badbehavior_uninstall() to do these tasks for you.

I include my patched module file. Beware this is for Drupal 5.x and BB2, not Drupal v4.7!

Re #3 and #4: Inside badbehavior.module, there is a bb2_install function that indirectly calls bb2_table_structure. Doesn't this do what you ask for in #3? If not, what am I missing?

Thanks, Ron.

Hello Folks!

With all the brilliant work done so far on this Drupal 5 module and the Drupal 6 version. I thought it would be appropriate to roll up a new version of the module with some install/uninstall hooks. Much of what pobster did has helped to clean up this edition of the module.

I hope it meets everyones needs and expectations.

I've taken the patch and reworked the module with some of the work done on the Drupal 6 version. I'm closing this ticket as I've released a BETA version of the module with all these points taken into consideration.

Apparently I did something wrong with my uploading tarballs -- instructions were lost in translation. So, I'm including the file here.