Closed (won't fix)
Project:
Drupal.org content
Component:
Case studies
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
12 Aug 2012 at 15:07 UTC
Updated:
27 Sep 2013 at 10:51 UTC
Jump to comment: Most recent file
Comments
Comment #1
silverwing commentedTo add inline images, upload your smaller pics to this issue and reference them with img src= (plus alt and title) in your text. (Just remember, images are to enhance text, not replace it; and too many images can detract from the text.)
Comment #2
z.stolar commentedThanks @silverwing.
I tried that, and got this error message (i copied the text as it didn't get in the capture). See the attached file.
Comment #3
silverwing commentedComment #4
silverwing commentedImage fixed now using image in comment#3. Not sure why it wasn't working before.
Comment #5
z.stolar commentedCool, thanks! I'll try some more tomorrow (not too many :) )
Comment #6
z.stolar commentedAdding some more images as suggested above.
Comment #7
z.stolar commentedsome more. sorry for the spam.
Comment #8
z.stolar commentedok, I tried with a couple more images, and I get the same error.
What needs to be done to get the images to display?
Comment #9
lisarex commentedWhat a great looking site!
Couple notes about the case study
1) I suspect the main image is too tall; I'm not sure how it will appear on the home page, but maybe tvn can confirm if it's a problem or not
2) Broken images... could it be because the filenames have so many spaces in them?
3) The post could do with a cleanup to fix punctuation and remove smilies (I don't think they belong in a Featured case study ;))
4) Use emdash rather than a single hyphen
5) You've got a lot of words in quotes that shouldn't be.
6) Paragraph spacing needs work.
If you're cool with it, I can make these edits directly (and you can revert if you disagree).
Comment #10
z.stolar commentedAre you kidding me?! Of course I'm cool with it. Thanks!
Just so you won't waste your time, I'll go over the post again, trying to fix some of the issues you mentioned, and if there's still work to do, you can give the last touches. Since I'm not an native English speaker, I may have some punctuation problems, but I'll do my best to remove/add the necessary ones.
I'll ping you once I'm done . Thanks again.
Comment #11
z.stolar commentedOK .
Thank you!
Comment #12
z.stolar commentedI opened a new issue for the local images: #1729500: Problems when linking to images in a case study
Comment #13
z.stolar commentedRe-Attaching some images without spaces in the file name
Comment #14
z.stolar commentedComment #15
z.stolar commentedAny chance this gets featured before Drupalcon Munich? :)
Thanks
Comment #16
Tezza commentedHey Zohar
I've had a good read through this case study and have attached a re-write.
I intended to do just a spelling and grammar check but I struggled to get past some of the sentence structure.
Please take from it what you think is appropriate but do have a good read before replacing your own words, just in case I have incorrectly reinterpreted some key points.
I too have an issue with hyphens / em dashes and double/single quotes so I'll have a proper scan through the case study once you've applied the changes you feel are of benefit.
Please note that I moved some sentences, cut some and added some. I tried not to remove the obvious (and welcome) bits of humour and personality - hopefully you still recognise it!
Again, please read the suggested changes thoroughly before applying them and feel free to omit what you don't like or don't agree with.
It still needs a second reading before promotion. I'm not completely happy with my version but I'll need to leave it a day or so before I re-read it objectively.
Regarding the line about DrupalCon Munich coupons - this sentence will be outdated pretty fast :)
Great website. +1 from me when the case study is up to par.
Comment #17
lisarex commentedHey Zohar, Tezza is a wonderful writer / editor so I won't do any direct edits right now, but I will review your revision after you incorporate any of Tezza's suggestions.
Your images are looking much better (that is, they're appearing, so yay!)
"Many bug fixes in various modules" -- can you provide a couple examples?
One other comment is in the project team section. This is meant to be a place to recognize the names of the people who aren't on d.o., maybe explain everyone's roles. We had to crack down on people being too promotional about their own company so I am going to suggest removing the line "The wonderful team at Linnovate is responsible for this art piece". Fine if you want to keep something like "On the client's side, we had the pleasure of working with David Balsar, Eyal Shahar, Amir Sher and Nir Ingbir."
Nearly ready to +1 and promote!
Comment #18
z.stolar commented@Tezza: I went on and incorporated most of your changes - you've done a remarkable work that makes me understand better the role of a linguistic editor! It seems to me that even I understand my words better now! :)
I reverted some changes you made, very few though. As for the coupons - I removed it, and will add it in another post, so it's not outdated once DC is over.
@lisarex, I removed the glorifying credits to my team. There's no doubt that in third and fourth reading, they do seem a bit too much. I'll see if there's a way to track down all of the small fixes we contributed here and there, and list it in a condensed manner.
Comment #19
lisarex commentedI made some minor punctuation / text fixes and this is +1 for promotion from me!
Comment #20
Tezza commentedLooks good to me too.
Great work all (and thanks for the kind words, lisarex and z.stolar).
+1
Comment #21
robertdouglass commentedGreat study that clearly shows the value of Drupal + Commerce! Can hardly wait to see this up on the big board =) Thanks lisarex and Tezza for helping get it in good shape.
Comment #22
tvn commentedPromoted! Thanks everyone for a great case study.
Re: #9 our usual problem is that images are too short, so let's see how this tall one will look on the front page. we'll shorten it if needed.
Comment #23
lisarex commentedTwo of my design colleagues thought the screenshot looks too tall. I agree that it's tall, but to crop it would be to ruin the story it's trying to tell.
https://skitch.com/lisarex/epuy2/drupal-open-source-cms-drupal.org
Thoughts?
Comment #24
Tezza commentedI think you're right on both counts.
As much as I'd like to see any homepage screenshot taken from the top down there may be a case for cropping this one just below the slideshow, to, as you say, tell the story.
This would help with the Featured slideshow too, which is not particularly impressive.
Comment #25
z.stolar commentedI'm on my way to drupalcon.... let me have a look in few hours when i'm nrxt to my pc :-)
Comment #26
tvn commentedI've changed main image on the slideshow and moved old one down to "Additional screenshots".
Comment #28
Tezza commentedComment #29
Tezza commentedAs raised in http://drupal.org/node/1899898 under.me is no longer using Drupal.
We've hidden the Featured case study but we're considering placing it in a new archive section with an explanatory paragraph and links to the website removed.
Would the author respond to either issue with his thoughts on this and perhaps a word or two on the switch from Drupal & Commerce?
EDIT: Author z.stolar contacted via d.o contact form on 30 Jan and referred to this issue.
Comment #30
lisarex commentedIt's been 6 months, so closing this.