Test contextual links

Yep, I'm noticing this too. The PHP Notice occurs only when there is no content on the site.

Contextual links are broken still broken.

How can I reproduce this and what contextual links are broken? I have not seen it and all my contextual links seems working.

I think it must be a mistake that this was marked "Closed (cannot reproduce)" since several people are able to reproduce it. I, for one, have encountered it just now on my fresh sandbox.

Are you able to describe how and under what url? Maybe add screenshots, too.

Whenever I visit /admin/workbench, the next page that I visit after I close the overlay looks like this. (Screenshot attached).

Enabled contrib modules are: CTools, Devel, Git Deploy, Views 7.x-3.x-dev, and Workbench 7.x-1.2.

You do not have WBM or WBA installed?

How about the patch from #1?

I do not have WBM or WBA on this particular test site.

I still get the errors when I try the patch in #1. Only disabling the contextual module seems to get rid of it.

I got the patch to apply and wrote some tests.

Attached you'll find the patch with tests, as well as tests only. The tests will not fail without the patch, however, they will display exceptions as shown in the attached screenshot. With the patch applied, the tests will pass without exceptions.

I have so far not observed misplacement of the contextual links.

We need to rerole for #1388220: Actions Missing in My Edits. Additional I think there is something wrong with this patch.

+++ b/workbench.pages.incundefined
@@ -60,7 +60,7 @@ function workbench_content() {
-        views_add_contextual_links($output[$key]['contextual_links'], 'block', $view, $display_id);
+        views_add_contextual_links($output[$key]['#contextual_links'], 'block', $view, $display_id);

I believe it need to be $output[$key] only. The rest is handled by views_add_contextual_links(). I say this only codewise, so it's not tested yet, but I give it a try. By prefixing the name with a sharp you made it falling back to sane defaults if I'm not totally wrong.

I'm still totally unable to repro this warnings. I have installed only workbench module and no WBA or WBM. Drupal 7.18

I had this same issue, but I didn't have views_ui enabled. After enabling Views UI, the error went away. (This is without using any of the aforementioned patches on this thread).

Does anyone get the error WITH Views UI enabled? The contextual link code should check for Views UI anyway, and that made it into a commit on this issue: http://drupal.org/node/1388220

Ok, reproduced it. Views UI need to be disabled and if (module_exists('contextual') && module_exists('views_ui')) { need to be roled back to if (module_exists('contextual')) { for repro. So, this is a duplicate of #1388220: Actions Missing in My Edits.

Stop, there are tests inside.

• #13 has disabled the contextual links completely.
• Patch has now no missing newline in .info.
• Added test coverage if the contextual links are really shown

+++ b/workbench.testundefined
@@ -0,0 +1,68 @@
+    // Navigate to the Workbench dashboard, then back to the frontpage to get errors in the contextual filter module
+    $this->drupalGet('/admin/workbench');

$this->drupalGet('admin/workbench')

Contextual links are not appearing. This is JS, isn't it? I'm out for tonight... looks not testable :-(.

The test I posted doesn't test whether the contextual links are in the right place or even whether they work. Rather, the test generates errors without the patch, and does not generate errors when the patch is applied. That is all.

#13: 1727284-workbench-contextual-tests-only-13.patch queued for re-testing.

The commit that fixed #1388220: Actions Missing in My Edits also resolved this problem for me. Queued the tests from #13 for re-testing because I think they will not produce errors on the latest codebase.

Update: they now pass with no errors. I believe this is fixed.

Er, what I meant was... #1388220: Actions Missing in My Edits

#21 needs work.

I'm confused. What needs work? Is it not true that pulling the latest dev resolves this issue?

I think hass wants to get the tests in. I'm not sure they work correctly yet though.

Yep, I'd like to get the tests in for future.

#16: workbench_1727284+Contextual+links+error+on+Drupal+7.15.patch queued for re-testing.

Hi.

I tested patch #16 and it is working.

Will it be added to the official release?

Regards,
Gilsberty

I've pulled the latest dev and the issue is gone. So the Needs work only applies to getting the tests in, the rest is not needed.

Using the latest stable version (7.x-1.2) and with Views UI disabled, I'm getting the warnings:

Warning: Invalid argument supplied for foreach() in contextual_pre_render_links()

To recreate, add a view of some sort with a page display, add a tab menu that appears within workbench (admin/workbench/my-view).

Any chance of getting this fixed soon? I don't like to have Views UI enabled on production, but I also dislike warnings and errors.

Any updates on this?

Patch #1 does the trick and it seems fairly logical.

Patch from #1 works perfectly fine for me.

Patch #1 also works for us. We're in the same situation as you, @ebeyrent: Workbench 7.x-1.2, views_ui disabled. Works great!

I'm also having this issue and as stated by @bbinkovitz on comment #8, this can be reproduced by going to the admin/content/workbench page or just visit the page more than once like just refresh the page the error them is shown.

Indeed the patch in comment #1 removed the error.

Some modules versions used

• Drupal Core 7.41
• CTools 1.9
• Workbench 1.2
• Views 3.11 (Views UI Disabled)

In my case the module views_ui was disabled and for some reason it was causing the problem.
Without any patch and enabling the module views_ui the error went away.
Maybe it can help someone.