Strict warning: Creating default object from empty value in uc_coupon_load() (line 13 of /sites/all/modules/uc_coupon/uc_coupon.entity.inc).

function uc_coupon_load($cid) {
  $coupon = db_query("SELECT * FROM {uc_coupons} WHERE cid = :cid", array(':cid' => $cid))->fetchObject();
  $coupon->data = isset($coupon->data) ? unserialize($coupon->data) : array();

should be replaced with the following .

function uc_coupon_load($cid) {
  $coupon = db_query("SELECT * FROM {uc_coupons} WHERE cid = :cid", array(':cid' => $cid))->fetchObject();

// check whether data is really fetched and $coupon is not NULL.  
   $coupon = is_Object($coupon)? $coupon : new stdClass();

  $coupon->data = isset($coupon->data) ? unserialize($coupon->data) : array();
CommentFileSizeAuthor
#8 uc_coupon-php_5.4_1727772-8.patch651 bytesjackalope
#1 1727772-uc_coupon_default_object-1.patch524 bytesrickmanelius

Comments

rickmanelius’s picture

rickmanelius commented
Status: Active » Needs review
StatusFileSize
new 1727772-uc_coupon_default_object-1.patch524 bytes

Attaching a patch from the issue summary (I can confirm that it works, but need someone else to review).

rickmanelius’s picture

rickmanelius commented

Hi @amar.deokar,

Can you check real quick so we can mark this one line patch as RBTC?

-Rick

wodenx’s picture

wodenx commented
Status: Needs review » Fixed

This looks fine to me. Committed. Thanks both for the patch.

amar.deokar’s picture

amar.deokar commented

Thanks guys !

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

comment was corrected in code tag.

swatchion’s picture

swatchion commented

thank you, this patch works like a charm.

GARONNE Bruno’s picture

GARONNE Bruno commented

Thank guys !
Your patch work ;)

jackalope’s picture

jackalope commented
Issue summary: View changes
StatusFileSize
new uc_coupon-php_5.4_1727772-8.patch651 bytes

The same problem exists in the 6.x-1.7 version of uc_coupon, but the fix in the patch for Drupal 7 works for Drupal 6, too. I've attached a patch for D6 in case anyone needs it!

matt.rad’s picture

matt.rad commented

I get this error when I enable the Discount Coupon Purchase submodule, using 7.x-2.1-alpha7, but not otherwise. Will this patch be rolled into a version of the module for release?

drupalove’s picture

drupalove commented
Issue summary: View changes
DrCord’s picture

DrCord commented

This patch seems to work fine for the site I admin that it is running on .