I'm getting IE7 JS alerts from D6 Head. Places to check. There maybe more hot spots.

/user/XXX/edit (collapse theme configuration)
/admin/build/modules (get an error without clicking anything)

CommentFileSizeAuthor
#1 tableheader_height.patch843 bytesChrisKennedy

Comments

ChrisKennedy’s picture

ChrisKennedy commented
Status: Active » Needs review
StatusFileSize
new tableheader_height.patch843 bytes

Renaming a variable (.height -> .savedHeight) in misc/tableheader.js fixes the bug.

anders.fajerson’s picture

anders.fajerson commented
Status: Needs review » Reviewed & tested by the community

No more error on /admin/build/module in IE7.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Needs review

What about the other alert?

jrabeemer’s picture

jrabeemer commented

This needs to get in before beta!

bdragon’s picture

bdragon commented
Title: JS alerts in IE7 D6 Head » beta breaker: JS alerts in IE7 D6 Head

Then beta breaker it!

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

As far as I see, this fixes one of the reported two alerts. Therefore I asked: what about the other alert?

jrabeemer’s picture

jrabeemer commented

This patch DOES NOT fix the "/user/XXXX/edit" issue. In order to recreate, you must enable more than one theme and also give change theme permission to the user! The "Theme Configuration" will only appear there if you set those conditions.

ChrisKennedy’s picture

ChrisKennedy commented

This fixes both alerts, which are due to same bug. If you are testing this patch, remember to turn off JS aggregation and do a hard-reload after you apply it to load the updated js file.

If the alert still exists, please let me know how you are getting it.

anders.fajerson’s picture

anders.fajerson commented
Status: Needs review » Reviewed & tested by the community

Yep, fixes the error on /user/XXX/edit (collapse theme configuration) as well.

jrabeemer’s picture

jrabeemer commented

Ok. I'll test again. FYI, http://drupal.org/node/174708 adds jQuery 1.2 which will probably break this patch. :-/

ChrisKennedy’s picture

ChrisKennedy commented

To elaborate: the error occurs wherever there is a collapsible fieldset with a table inside it that has a header. There is only a single bug: the two pages listed happen to have this combination of form elements. The bug would also occur in any contributed module or other core module where this happens.

jrabeemer’s picture

jrabeemer commented

I dumped all my previous patches and updated to CVS and patched to this. It works! Ready to go!

ChrisKennedy’s picture

ChrisKennedy commented

Regarding #10: no. It does not break this patch, nor does it fix this issue.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Happy to hear about the tests! Thanks a lot, committed.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)