Webapp Module adds functionality for iOS specific devices for Drupal 7
https://drupal.org/sandbox/Grienauer/1532258

  • deliver App icons for all different iOS devices like iPad, iPhone and iPod Touch and for devices with Retina displays
  • Startup Images for all different iOS device/screen Sizes and pixel ratio
  • prevent links in standalone iOS web applications to open Mobile Safari App
  • easy meta-tags configuration
  • Viewport settings
  • display "Add to Home screen" box to users and include the library
  • Phone number detection switch
  • Tap highlight switch
  • Homescreen App title (only iOS6)

It's my first module and I am a designer... so please have patience with me :)

Comments

jibus’s picture

jibus commented
Status: Reviewed & tested by the community » Needs work

Hello !

Did a manual review of your code

- It seems that you have used custom indentation. Please see : http://drupal.org/coding-standards/#indenting
- If you use variable_get() function, you have to set a default value.
- For clean uninstall, you should create a .install file and use variable_del() in order to remove variable properly.
- I am not sure that "/sites/default/files/ios/" is a good location for images.

I did also an automated review which show some of the errors that i mentionned earlier.

I hope i could help :)

Update status to "need work"

mschudders’s picture

mschudders commented

As Jibus stated but with more comment:

Remove LICENSE.txt, it will be added by drupal.org packaging automatically.
Remove "version" from the info file, it will be added by drupal.org packaging automatically.

and a lot of coding standards errors:
see : http://ventral.org/pareview/httpgitdrupalorgsandboxmasoodanwer1717534git

and also see if using eclispe (will fix much errors fast)
: http://drupal.org/node/75242

Chris Charlton’s picture

Chris Charlton
Primary language English
Location Los Angeles
commented

@Grienauer consider using the Coder module, and Coder Tough Love addon.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

grienauer’s picture

grienauer
he/him
Primary language German
Location Vienna
commented
Issue summary: View changes
Status: Closed (won't fix) » Needs review

Changed the module code, added some features/noticed the tipps from other users (thx fot that) and most important: fixed the errors the automated reviewer showed :)

So I have reopened this issue for hopefully get this to a full project page :)

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Postponed (maintainer needs more info)

https://drupal.org/project/ios_webapp

This sounds like a feature that should live in the existing ios_webapp project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the ios_webapp issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

grienauer’s picture

grienauer
he/him
Primary language German
Location Vienna
commented

our webapp module is not ios specific. Also it has more features then the ios_webapp module and uses different approaches of getting e.g. the right startup image for ios... also it supports Android Startup Icons and I am working on Windows Phone support with specification of a rss link... in the project overview there are not all features listet :( I have to tighten these information!

It also has the option to include a "add to homescreen" animated box with the library module, disabling of phone number detection, add a homescreen title, selection of status bar screen, prevent to open external link in a new window,...

the main feature of webapp_ios is dispaying Startup Images and we have a different approach of delivering them (with a js script) because on ios there are some issues and not everything could be detected with mediaqueries...
Also the webapp_ios module has only a Drupal6 Version... and we only 7 and not just for iOS support :))

So I think it is justified to have a new Module :)
I Hope! :)

Andre-B’s picture

Andre-B
Primary language German
Location Offenburg, Germany
commented
Status: Postponed (maintainer needs more info) » Reviewed & tested by the community

UI

Code

code sniffer looks fine:

Andres-MacBook-Pro:webapp andrebaumeier$ drush dcs

PHP_CodeSniffer did not find any problems.

Feature request

drush command for installing the additional add-to-homescreen library

Andre-B’s picture

Andre-B
Primary language German
Location Offenburg, Germany
commented
Status: Reviewed & tested by the community » Needs work
grienauer’s picture

grienauer
he/him
Primary language German
Location Vienna
commented
Status: Needs work » Reviewed & tested by the community
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Reviewed & tested by the community » Fixed

manual review:

  1. the JS files should use 2 space indentation.
  2. webapp_init(): this should actually be hook_page_build(), since it does not make sense to add JS/CSS on drush invocations or other requests.

But otherwise this looks good to me, and Andre-B seems to agree as well apart from some minor issues, so ...

Thanks for your contribution, Grienauer!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.