Now that aggregator.module is no longer broken beyond all recognition (thanks guys!), the page split is now easy!

CommentFileSizeAuthor
aggregator_11.patch63.02 KBCrell

Comments

fgm’s picture

Status: Needs review » Needs work

Not sure whether these come from the patch, but there seem to be some issues with aggregator menus. Using paths:

  1. aggregator shows a list of posts with the title "news aggregator" and breadcrumbs (bc) limited to "Home", no local tasks
  2. aggregator/categories shows a list of categories and their most recent posts, with bc "home > news aggregator"
  3. aggregator/categories/<cid> shows a visually identical list of posts with the same title as in (1), the same bc as in (2), and local tasks, but no title or mention in the bc about the current category

This seems inconsistent: it seems that

  • (1) should have the local tasks
  • (2) is correct
  • (3) should have bc including a link to level (2) and a title containing the current category

Otherwise we're missing consistency.

Again, this might not be due to the patch, but a preexisting error that should be fixed, possibly by this patch since it redistributes content.

Crell’s picture

fgm: Can you check without the patch and see if those problems are there before hand? If so, I'd rather apply the patch now and fix them later as the split patches are fragile, since they touch so much. As long as it's not introducing any new bugs, it should be fine.

eagle15’s picture

Status: Needs work » Needs review

I've verified (with a clean checkout) that the aggregator issues mentioned exist before this patch.

dvessel’s picture

Status: Needs review » Reviewed & tested by the community

Only point 3 is different from 5.x. Doesn't mean it's correct but if anyone wants to change that, lets leave that to another issue.

Works without problems.

dries’s picture

Status: Reviewed & tested by the community » Needs work

I've committed this patch but we probably want to file an issue for the remaining issues.

fgm’s picture

Status: Needs work » Fixed

I created a separate issue at http://drupal.org/node/173188 for the menu / breadcrumbs consistency problem, so this patch can rest in peace, since it appears to be a separate problem.

Anonymous’s picture

Status: Fixed » Closed (fixed)