I have performed few code style fixes mainly with dyoxygen docs in apps.manifest.inc but also got rid of PHP notices for certain cases when you have minimalistic manifest definitions (e.g. without screenshots).

Please review the patch.

CommentFileSizeAuthor
#5 apps-code-style-fixes-1728432_0.patch9.12 KBneochief
#3 apps-code-style-fixes-1728432.patch9.33 KBneochief
#1 apps-code-style-fixes-1728432.patch9.33 KBneochief

Comments

neochief’s picture

neochief commented
StatusFileSize
new apps-code-style-fixes-1728432.patch9.33 KB
febbraro’s picture

febbraro commented
Status: Needs review » Needs work

This looks good and I tried to commit, but the patch does not cleanly apply for me. Can you reroll it?

neochief’s picture

neochief commented
Status: Needs work » Needs review
StatusFileSize
new apps-code-style-fixes-1728432.patch9.33 KB

Try this one.

febbraro’s picture

febbraro commented
Status: Needs review » Needs work

Hey @neocheif, I'm sorry, it still does not apply. By looking at the start of your patch (seeing the define labeled INSTALLABLE) it seems like this is based on a pretty old version of the source code. Can you try to merge in the latest changes in the dev branch see how that goes?

Here are my errors. http://cl.ly/image/3F3g1f0w3o3S

neochief’s picture

neochief commented
Status: Needs work » Needs review
StatusFileSize
new apps-code-style-fixes-1728432_0.patch9.12 KB

Here's the re-roll. Tested patch with your commands, it works, except 5 whitespace warings, which is not critical. In case I've chosen wrong branch, I'm creating patches against 7.x-1.x.

hefox’s picture

hefox commented
Issue summary: View changes
Status: Needs review » Needs work

Another code style issue was commited so please reroll with whatever left to be changed.

I believe param structure is
@param [type]
description

e.g. two lines