Flexible layout:

  1. resets canvas paddings (Column, Region and Row) to 0.5em if they are empty. Correct behavior: paddings must be "0" instead
  2. skips parent css class ($owner_id in code) when applying css rules, making rules common and affecting any regions, i.e. not current layout's specific ones.
CommentFileSizeAuthor
#3 panels-1728518-3.patch2.77 KBOnkelTem
#1 panels-1728518-0.patch3.9 KBOnkelTem

Comments

OnkelTem’s picture

OnkelTem commented
Status: Active » Needs review
StatusFileSize
new panels-1728518-0.patch3.9 KB
merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Needs work

While I agree with #2, I'm not sure I agree with #1. I think the default separations are correct.

OnkelTem’s picture

OnkelTem commented
Title: Flexible layout incorrectly treats canvas paddings » Flexible layout: set parent CSS class for layout
Status: Needs work » Needs review
StatusFileSize
new panels-1728518-3.patch2.77 KB
OnkelTem’s picture

OnkelTem commented

Please, submit this patch.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Committed and pushed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

akalata’s picture

akalata commented
Issue summary: View changes

This task was rolled into the 7.x-3.4 release, and can potentially break existing layouts. Discussing at #2197967: 3.4 adds css with increased specificity; may break custom layouts since this is an old thread.

  • Commit d7e5b38 on 7.x-3.x, 7.x-3.x-i18n, 8.x-3.x by merlinofchaos: 
    Issue #1728518 by OnkelTem: More specificity on flexible generated CSS.