The dependencies on og_forum is unnecessary I believe. The module seems to be using module_exists where needed.

This part at the end of the info file should not be hardcoded. It's added automatically by the project module when it builds the tarballs.

; Information added by drupal.org packaging script on 2007-08-01
version = "5.x-2.0"
project = "og_user_roles"
datestamp = "1185930942"

P.S I have now installed this module live on a big Swedish site that use organic groups. I will make sure to report any issues and, if I can, patches for them. Thanks again for contributing this to the community!

CommentFileSizeAuthor
og_user_roles.info_code_cleanup.patch843 bytesfrjo

Comments

somebodysysop’s picture

somebodysysop commented
Status: Needs review » Fixed

Thanks for the patch. Taking out those lines in next release. Leaving in og_forum requirement.

Coyote’s picture

Coyote commented

Why is og forums a requirement?

I have a site where I'd like to use this module, but we do not need or want forums.

Is og forums really necessary to use this module? Will having og forums installed, but no forums created (or users not having access to them) work?

somebodysysop’s picture

somebodysysop commented

og_forums installs the og_term table which has been used by og_user_roles since it's inception as one way of determining the group(s) a node belongs to. The table is referred to in 3 places, so that's why I'm keeping og_forums as a requirement.

Having forums installed, but no users having access to it will work.

Coyote’s picture

Coyote commented

Another thing to keep in mind is that og_forums _requires_ MySQL 5, which not everyone is using.

As far as determining which group a node belongs to, would something like nodefamily work for that?

somebodysysop’s picture

somebodysysop commented
Title: Cleanup path for og_user_roles.info » og_forum requirement for install (was: Cleanup path for og_user_roles.info)

I see your point. Assuming that you aren't using Forums, there appears to be just one place where og_term is absolutely necessary, and even then it's only required if you have enabled TAC/OG Integration.

Perhaps there is a way to have the TAC/OG integration button not be editable unless og_forum is installed?

somebodysysop’s picture

somebodysysop commented
Version: 5.x-2.3 » 5.x-2.4
Status: Fixed » Needs review

Just released version 5.x-2.4. In this release, I've removed the og_forum requirement. However, you cannot set TAC/OG Integration without og_forum module installed. Download it and see if it works for you.

Coyote’s picture

Coyote commented

Thank you so much! I hope it doesn't sound silly to say that this made my day!

somebodysysop’s picture

somebodysysop commented
Status: Needs review » Fixed

Trust me, I understand. I'm not just a module contributor, I'm also a module user.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)