Administrative view of all comments by a user

Overridden Comment view: drupalorg_admin_comments_by_user

path: user/%/admin-comments

CommentFileSizeAuthor
#7 doobie-admin-comments-1729862-7.patch4.27 KBeliza411
#4 doobie-admin-comments-1729862-1.patch4.33 KBkssundar

Comments

kssundar’s picture

kssundar commented
Assigned: Unassigned » kssundar

Taking this up.

kssundar’s picture

kssundar commented
Status: Active » Postponed
Issue tags: +sprint 4

Found that this one is similar to #1719278: Write Feature File/s for Drupal.org to get Administrative view of all nodes by a user (user_admin_nodes.feature). Here it is comments instead of nodes. Once that issue is fixed, I will upload the patch here.

kssundar’s picture

kssundar commented
Status: Postponed » Active

re-opening and working on this as user_admin_nodes.feature is committed to repo.

kssundar’s picture

kssundar commented
Status: Active » Needs review
StatusFileSize
new doobie-admin-comments-1729862-1.patch4.33 KB

Attached is the patch for this feature. Needs review.

kssundar’s picture

kssundar commented
Title: Administrative view of all comments by a user » Administrative view of all comments by a user (user_admin_comments.feature)

Change title to include feature file name

eliza411’s picture

eliza411 commented
Component: Feature/Scenarios » Step Definitions

This looks ready for code review. I tabbed out the table and un-remmed the dangerous bits since there's no "admin user" on production and these tests should not be used against production (See #1737286: Prevent test usernames from ever being used on production)

eliza411’s picture

eliza411 commented
StatusFileSize
new doobie-admin-comments-1729862-7.patch4.27 KB

Attaching the revised patch and advancing for code review.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Component: Step Definitions » Environment setup
Status: Needs review » Needs work

I get a fatal: corrupt patch at line 131 when attempting to apply the patch in #7. Feel free to commit to the 6.x branch for review.

kssundar’s picture

kssundar commented
Component: Environment setup » Feature/Scenarios
Status: Needs work » Needs review

Committed to repo - http://drupalcode.org/project/doobie.git/commit/c95a5f6

kssundar’s picture

kssundar commented
Issue tags: +sprint 6

tagging

eliza411’s picture

eliza411 commented
Component: Feature/Scenarios » Step definitions

Looks like this has been committed for code review - setting status accordingly.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs review » Reviewed & tested by the community

I added a clarifying code comment in 130ee1f for allTheCheckboxesAreSelected().

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Reviewed & tested by the community » Fixed

Merged to master.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

pradeeprkara’s picture

pradeeprkara commented
Version: » 6.x-1.x-dev
Issue tags: +sprint 18

Ported to 7.x branch.
Tagged the failing scenarios.

http://drupalcode.org/project/doobie.git/commit/64ede43
http://drupalcode.org/project/doobie.git/commit/46ad301

pradeeprkara’s picture

pradeeprkara commented

Some more updates here: http://drupalcode.org/project/doobie.git/commit/fca974b