Excellent module, extensive work.

use standard name media_mover or mm; not both.

suggest module name mmapi that includes only core code functions with docs to facilitate contributions.

Comments

robloach’s picture

I also think that choosing a standard is a good idea, for the variable named as well. The modules are named "media_mover", "media_mover_ffmpeg", etc, you'd think the best naming choice for the modules and the variables would be "media_mover_%", "media_mover_ffmpeg_%", "media_mover_email_%", etc.

arthurf’s picture

Ok! These are both interesting suggestions. I've started doing something along the lines of what I think the intention is:

1) Split the media_mover.module from media_mover.inc
2) Changed media_mover.module to media_mover_api.module which is all of the core functions
3) Changed all the functions in media_mover.inc to mm_node.module

I'm sticking with the mm_ for the non-core modules for right now, though I dare say it makes sense to change it. My thinking is that the module names are just going to get really long which can pose problems for the system and variables tables. If people think it should be changed, then I'll get to work on it, but for now.... mm_

Asper the function names, I'm going to start cleaning some of this up, but it is a time consuming job. I also want to do some coding cleanup in the process so I think it will be a piecemeal effort...

Thanks for the feedback, it's really great to see that people are looking at these modules.

andrabr’s picture

Title: Media Mover structure » Media Mover API
Version: 5.x-1.x-dev »
Component: Code » Documentation

Oooooh, this is so sexy!
Please please please document the API with examples for the simpletons like me, and we WILL write lots and lots of cute little modules!

arthurf’s picture

Thanks! There is some documentation on the readme.txt file, but more is forthcoming, it just is taking me time. Right now the priority is on really hammering out the core functionality so people will start writing those modules :)

I'm really hoping to interest people in this project, so if there are things you'd be interested in, please let me know- I'd like to make it as easy as possible to get people writing!