Refactor pager_query so pager can be used outside pager_query

Posted by douggreen on September 4, 2007 at 7:20pm

Issue Summary

I was working on the z3950 module, which implements hook_search to display content from z39.50 (library) servers. The results being displayed aren't from a Drupal database, so pager_query() can't be used. But, there are lots of results, that can be chunked into pages, and thus should use the Drupal paging system.

The attached patch slightly refactors pager_query, keeping the original functionality intact, but exposes a new function called pager_init() which can be used by contrib modules.

Attachment	Size	Status	Test result	Operations
pager_5.patch	2.03 KB	Ignored: Check issue status.	None	None

Comments

#1

Posted by douggreen on September 4, 2007 at 7:22pm

... removing one extraneous line in patch file

Attachment	Size	Status	Test result	Operations
173037.patch	2.02 KB	Ignored: Check issue status.	None	None

#2

Posted by moshe weitzman on September 9, 2007 at 1:27am

i once did this without a patch: http://cvs.drupal.org/viewvc.py/drupal/contributions/tricks/pager_withou.... that might have bit rotted since then. maybe this patch is useful still - i dunno.

#3

Posted by douggreen on September 11, 2007 at 7:48am

Yes, it can be done without a patch. I'm just proposing some refactoring so that we get a new API function that makes it easier to do. Compared to your "trick" solution, what you get by using the pager call is an additional calculations on page position.