When setting params on the query object, setting a values like PHP TRUE for 'fl' or 'spellcheck' results in an error.

We should normalize the params for better DX so a boolean is automatically converted to its string representation.

CommentFileSizeAuthor
#4 1730840-4.patch2.4 KBpwolanin
#3 1730840-3.patch1.53 KBpwolanin
#2 1730840-2.patch1.52 KBpwolanin
#1 1730840-1.patch1.52 KBpwolanin

Comments

pwolanin’s picture

pwolanin commented
Status: Active » Needs review
StatusFileSize
new 1730840-1.patch1.52 KB
pwolanin’s picture

pwolanin commented
StatusFileSize
new 1730840-2.patch1.52 KB

fix code comment and rename variable.

pwolanin’s picture

pwolanin commented
StatusFileSize
new 1730840-3.patch1.53 KB

missed one. ignore #2.

pwolanin’s picture

pwolanin commented
StatusFileSize
new 1730840-4.patch2.4 KB

With small added unit test assertions.

pwolanin’s picture

pwolanin commented
Title: Boolean values may fail for parameters like hl » Normalize boolean and other values for parameters like hl
Status: Needs review » Fixed

applied #4 to 7.x and 6.x-3.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.