Closed (fixed)
Project:
Coder
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
5 Sep 2007 at 13:58 UTC
Updated:
20 Sep 2007 at 09:21 UTC
Hi,
I'm using this module to help me convert my modules from Drupal 5.x to 6.x. I had updated my module with the new l() arguments. Since I didn't need to set the "attributes" and "query" options, I changed it to:
$back_to_top .= l(t($display_vars['back_to_top']), 'faq', array('fragment' => '')) .'</p>';
However, this continued to give me the "Line 827: url() and l() arguments changed, if you have a lot of these use this conversion script (Drupal Docs)" error. The above should work though, shouldn't it? I eventually changed this line to the one below and the error disappeared.
$back_to_top .= l(t($display_vars['back_to_top']), 'faq', array('attributes' => array(), 'query' => NULL, 'fragment' => '')) .'</p>';
In the meantime, while updating a different module, the coder module didn't detect the following old usage of the l() function:
$link_attributes = array(
"rel" => $rel,
"title" => $item["alt"] . $node_link
);
$output = l($image, $item['filepath'], $link_attributes, NULL, NULL, FALSE, TRUE);
Cheers,
Stella
Comments
Comment #1
douggreen commentedI found the problem in the regex used to parse arguments, wasn't properly looking for $vars as arguments (an obviously big oversite). I've updated the 5.x and 6.x dev versions to include the fix. Please test. Thanks!
Comment #2
stella commentedYep, that's fixed it, at least in the 6.x version. Thanks.
Cheers,
Stella
Comment #3
(not verified) commented