Needs work
Project:
Cookie Control
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
15 Aug 2012 at 13:30 UTC
Updated:
21 Nov 2013 at 15:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
pwhite commentedI would second this, the performance recently has been a big problem on some of my sites.
I've been commenting out line 63 of cookiecontrol.module as a quick fix.
//drupal_add_js('https://www.geoplugin.net/javascript.gp', array('type' => 'external'));
Comment #2
lethallynx commentedI would 3rd this, it's defiantly slowing page load times and it accesses the service every damn page.
Even if the module could cache the results for a specific IP and reuse them.
Comment #3
buddaDownload the data locally could be automated in a similar way that the drupal google analytics module does it, and stores it in the files/ folder for a while.
i'm open to patches for this.
I have noticed the geo server does slow down every now and then.
Comment #4
buddaif you just set your country list to be empty then no geo js will be loaded anyway.
Comment #5
lethallynx commentedYeah but if you want to actually just limit to countries that require it, then you need to use the field.
Comment #6
buddamy suggestion was just instead of commenting out module code for now.
I'm hoping somebody has time to submit a patch to cache the geo data locally like GAnalytics module does. Fingers crossed.
Comment #7
snufkin commentedHere is my take on a possible geoip support. The patch does not introduce geoip as a dependency but instead adds an admin setting, which is only enabled when the module is available. Once the admin setting is turned on to use the module, that API will be used instead of geoplugin.
Comment #8
snufkin commented