Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
when I try to upload more than 20 files, only first 20 are uploaded (regardless size)
using combination:
Multiupload Filefield Widget -> Multiupload Imagefield Widget -> Galleria
also the files are loaded in strange order (always the same - 1st, 15th, 14th, 13th, 12th, 16th, 17th, 20th, 19th, 18th, 11th, 10th, 4th, 3rd, 2nd, 5th, 6th, 9th, 8th, 7th)
I'm using weight for sorting, so have to change almost all manually
Comment | File | Size | Author |
---|---|---|---|
#9 | multiupload_filefield_widget-sort_order-1733898-3.patch | 529 bytes | lolmaus |
Comments
Comment #1
darvit CreditAttribution: darvit commented20 file limit is set in PHP;
See previous issue:
http://drupal.org/node/1345634
Comment #2
postak CreditAttribution: postak commentedok, understand the 20 limit, thanks!
changing the title of the issue
Comment #3
arseniew CreditAttribution: arseniew commentedquick (and propobly dirty) fix for files order:
in multiupload_filefield_widget.field.inc
replace
$element_children = element_children($element, TRUE);
with
$element_children = element_children($element, FALSE);
Comment #4
pedromvpg CreditAttribution: pedromvpg commentedNice! Thanks!
Comment #5
thatjustin CreditAttribution: thatjustin commented#3 Works perfectly for me. Any thing that should be watched out for? arseniew mentioned it was "dirty", but I don't know what to watch out for.
Comment #6
arseniew CreditAttribution: arseniew commentedthatjustin:
I didn't do any testing for that change, other than simply uploading files.
I have it live on my site for over a month and it seems to work right; i didnt experienced any data corruption or errors.
Only issue one user reported, was the fact that last file uploaded sometimes jump in the first place, although i wasn't able to reproduce that error.
Other thing you should watch for is updating this module, that will overwrite change made.
When im 100% sure everything works right i will try to commit this change to module.
Comment #7
postak CreditAttribution: postak commentedno problem with #3, works perfectly for me. thanks!
Comment #8
lv46gl CreditAttribution: lv46gl commentedHello, #3 works perfectly for me, thanks!
Comment #9
lolmaus CreditAttribution: lolmaus commented#3 worked flawlessly for me. Attaching a patch.
Comment #10
petu CreditAttribution: petu commentedWooooohoooo!! It works!! I mean the patch from #9...
Thank a lot!
Comment #11
jlbellido#9 works for me!! Thanks!!
Comment #12
czigor CreditAttribution: czigor commented88905fd5617c768f9a21f4f484720b4f1232ce2e Issue #1733898 File upload order
Comment #14
cjs_ CreditAttribution: cjs_ commentedI've applied the patch and verified that the line in question has been changed, but sorting behavior remains unchanged.
I'm a bit surprised as there seems to be (other than me) unanimous success with the change.
Any thoughts on why I might still be seeing the original sort behavior?
Comment #15
cjs_ CreditAttribution: cjs_ commentedI've now updated to the most recent dev version of the module, in which the call to element_children() has the second argument removed entirely (thus defaulting to FALSE) and still the original, odd sort behavior persists.
Comment #16
czigor CreditAttribution: czigor commentedYou don't need to patch anything, it's in 1.14. If it is still not working, please file a new issue.
Comment #17
hmartens CreditAttribution: hmartens commentedIs 1.14 the development version because the module is currently sitting on 1.13?
Comment #18
czigor CreditAttribution: czigor commentedMy bad, I meant 1.13.
Comment #19
trevorleenc CreditAttribution: trevorleenc commentedI am still experiencing this.
I am using 7.x-1.13+1-dev (2014-May-06), and the patch in #9 was not applied, but even after applying it, I still get a funky sorting of my files, even when uploading 5-7 at a time (which makes it easier to do because of this).
I also noticed that the patch was not in 7.x-1.13 either.
edit: I've tried combinations of TRUE or FALSE on that line, and it has not made any difference...
edit #2" ok, with FALSE on that line, and if I use the browser's open files, sorting comes out just fine, however, if I drag files onto the upload field, the sorting comes out all wonky and stuff...